public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: "Komal Shah" <komal.shah802003@gmail.com>
To: "Ragner N Magalhães" <ragner@users.sourceforge.net>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH]: Workqueue changes for board-h3
Date: Thu, 28 Dec 2006 20:18:44 +0530	[thread overview]
Message-ID: <3a5b1be00612280648v40a7b92eq35189cd68bc1bc9@mail.gmail.com> (raw)
In-Reply-To: <25c21ceb0612280531u2c01acfase9a95e81e6d37cfe@mail.gmail.com>

On 12/28/06, Ragner N Magalhães <ragner@users.sourceforge.net> wrote:
> ---------- Forwarded message ----------
> From: Felipe Balbi <felipe.lima@indt.org.br>
> Date: Dec 28, 2006 9:28 AM
> Subject: [PATCH]: Workqueue changes for board-h3
> To: ragner.magalhaes@gmail.com
>
> Hello all,
>
>
> This patch fixes an error regarding workqueue changes on board-h3 file.]
>
>
>
> =================== CUT HERE ==========================
> Fixes a compile issue when using CONFIG_MACH_OMAP_H3 regarding workqueues.
>
> Signed-off-by: Felipe Balbi <felipe.lima@indt.org.br>
> ---
>
> Index: linux-omap-2.6-dev/arch/arm/mach-omap1/board-h3.c
> ===================================================================
> --- linux-omap-2.6-dev.orig/arch/arm/mach-omap1/board-h3.c
> +++ linux-omap-2.6-dev/arch/arm/mach-omap1/board-h3.c
> @@ -298,5 +298,5 @@ static int h3_select_irda(struct device
>
> -static void set_trans_mode(void *data)
> +static void set_trans_mode(struct work_struct *data)
>  {
> -       int *mode = data;
> +       int *mode = (int *)data;

Did you tested this patch.? I am not sure this casting is the correct
way to go for it.


-- 
---Komal Shah
http://komalshah.blogspot.com

  reply	other threads:[~2006-12-28 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061228132843.6403.qmail@web33710.mail.mud.yahoo.com>
2006-12-28 13:31 ` Fwd: [PATCH]: Workqueue changes for board-h3 Ragner N Magalhães
2006-12-28 14:48   ` Komal Shah [this message]
     [not found] <31e679430612280750l77e590e4ice853ef8b4c3d05f@mail.gmail.com>
2006-12-28 19:33 ` Komal Shah
2007-01-02 20:35   ` tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a5b1be00612280648v40a7b92eq35189cd68bc1bc9@mail.gmail.com \
    --to=komal.shah802003@gmail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=ragner@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox