From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: "Vignesh Raghavendra" <vigneshr@ti.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"open list:PCI DRIVER FOR TI DRA7XX/J721E"
<linux-omap@vger.kernel.org>,
"open list:PCI DRIVER FOR TI DRA7XX/J721E"
<linux-pci@vger.kernel.org>,
"moderated list:PCI DRIVER FOR TI DRA7XX/J721E"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>
Subject: Re: [RFC v1 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable
Date: Mon, 13 Oct 2025 16:52:38 +0530 [thread overview]
Message-ID: <3c0f63162783f6eaa811901dbff9fbb4fe52c107.camel@ti.com> (raw)
In-Reply-To: <20251013101727.129260-3-linux.amoon@gmail.com>
On Mon, 2025-10-13 at 15:47 +0530, Anand Moon wrote:
> Change removes the unnecessary local gpiod variable and assigns the result
> of the devm_gpiod_get_optional() call directly to pcie->reset_gpio.
> This makes the code more concise and readable without changing the
> behavior.
>
> Cc: Siddharth Vadapalli <s-vadapalli@ti.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
> drivers/pci/controller/cadence/pci-j721e.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
[TRIMMED]
I have also tested the series (despite my feedback on the first patch).
Logs:
https://gist.github.com/Siddharth-Vadapalli-at-TI/ca82a16e15a892b3349396be17b37643
Please address the feedback on the first patch.
Regards,
Siddharth.
prev parent reply other threads:[~2025-10-13 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 10:17 [RFC v1 0/2] PCI: j721e: A couple of cleanups Anand Moon
2025-10-13 10:17 ` [RFC v1 1/2] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock Anand Moon
2025-10-13 11:13 ` Siddharth Vadapalli
2025-10-13 14:02 ` Anand Moon
2025-10-13 10:17 ` [RFC v1 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable Anand Moon
2025-10-13 11:22 ` Siddharth Vadapalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c0f63162783f6eaa811901dbff9fbb4fe52c107.camel@ti.com \
--to=s-vadapalli@ti.com \
--cc=bhelgaas@google.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).