Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Tony Lindgren <tony@atomide.com>, <linux-omap@vger.kernel.org>
Cc: Dave Gerlach <d-gerlach@ti.com>, Faiz Abbas <faiz_abbas@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Keerthy <j-keerthy@ti.com>, Nishanth Menon <nm@ti.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Kishon Vijay Abraham <kishon@ti.com>
Subject: Re: [PATCH] bus: ti-sysc: Fix external abort for am335x pruss probe
Date: Thu, 16 Sep 2021 11:54:40 -0500	[thread overview]
Message-ID: <3fd1968e-491e-6d98-ec9c-d29baed3158f@ti.com> (raw)
In-Reply-To: <20210915065032.45013-1-tony@atomide.com>

Hi Tony,

On 9/15/21 1:50 AM, Tony Lindgren wrote:
> Starting with v5.15-rc1, I'm now seeing am335x beaglebone black produce
> the following error on pruss probe:
> 
> Unhandled fault: external abort on non-linefetch (0x1008) at 0xe0326000
> 
> This seems to have started with the enabling of pruss for am335x in the
> dts files. Adding a read-back after write to the sysconfig register fixes
> the issue for me.

Let me take a look at this during the weekend. I did verify the AM335x PRUSS
when I posted the dts patches on 5.14-rc. You should be able to check as well
from your staging branch with PRUSS patches.

regards
Suman

> 
> Cc: Suman Anna <s-anna@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  drivers/bus/ti-sysc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -2037,6 +2037,9 @@ static int sysc_reset(struct sysc *ddata)
>  		sysc_val = sysc_read_sysconfig(ddata);
>  		sysc_val |= sysc_mask;
>  		sysc_write(ddata, sysc_offset, sysc_val);
> +
> +		/* Flush posted write */
> +		sysc_read_sysconfig(ddata);
>  	}
>  
>  	if (ddata->cfg.srst_udelay)
> 


  reply	other threads:[~2021-09-16 16:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  6:50 [PATCH] bus: ti-sysc: Fix external abort for am335x pruss probe Tony Lindgren
2021-09-16 16:54 ` Suman Anna [this message]
2021-09-21  7:55   ` Tony Lindgren
2021-09-21 15:58     ` Suman Anna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fd1968e-491e-6d98-ec9c-d29baed3158f@ti.com \
    --to=s-anna@ti.com \
    --cc=d-gerlach@ti.com \
    --cc=faiz_abbas@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=grygorii.strashko@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox