linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Nishanth Menon <nm@ti.com>
Cc: Russell King <linux@arm.linux.org.uk>,
	Tony Lindgren <tony@atomide.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH] ARM: OMAP2: Fix up interconnect barrier initialization for DRA7
Date: Fri, 11 Mar 2016 18:46:07 +0200	[thread overview]
Message-ID: <4167118.MBvk7Vsb05@avalon> (raw)
In-Reply-To: <1457712748-1408-1-git-send-email-nm@ti.com>

Hi Nishanth,

Thank you for the patch.

On Friday 11 March 2016 10:12:28 Nishanth Menon wrote:
> The following commits:
> commit 3fa609755c11 ("ARM: omap2: restore OMAP4 barrier behaviour")
> commit f746929ffdc8 ("Revert "ARM: OMAP4: remove dead kconfig option
> OMAP4_ERRATA_I688"") and
> commit ea827ad5ffbb ("ARM: DRA7: Provide proper IO map table")
> came in around the same time, unfortunately this seem to have missed
> initializing the barrier for DRA7 platforms - omap5_map_io was reused
> for dra7 till it was split out by the last patch. barrier_init
> needs to be hence carried forward as it is valid for DRA7 family of
> processors as they are for OMAP5.
> 
> Fixes: ea827ad5ffbb7 ("ARM: DRA7: Provide proper IO map table")
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reported-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
> Original thread of report:
> http://www.spinics.net/lists/dri-devel/msg101246.html
> 
>  arch/arm/mach-omap2/io.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
> index 3c87e40650cf..9821be6dfd5e 100644
> --- a/arch/arm/mach-omap2/io.c
> +++ b/arch/arm/mach-omap2/io.c
> @@ -368,6 +368,7 @@ void __init omap5_map_io(void)
>  void __init dra7xx_map_io(void)
>  {
>  	iotable_init(dra7xx_io_desc, ARRAY_SIZE(dra7xx_io_desc));
> +	omap_barriers_init();
>  }
>  #endif
>  /*

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2016-03-11 16:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 16:12 [PATCH] ARM: OMAP2: Fix up interconnect barrier initialization for DRA7 Nishanth Menon
2016-03-11 16:46 ` Laurent Pinchart [this message]
2016-03-30 21:11   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4167118.MBvk7Vsb05@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nm@ti.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).