From: Hema Kalliguddi <hemahk@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org
Subject: RE: [PATCH 1/2 v2] usb: otg: OMAP4430: Fixing the omap4430_phy_init function
Date: Tue, 29 Mar 2011 11:43:31 +0530 [thread overview]
Message-ID: <4369479157892165533add3d883a79a7@mail.gmail.com> (raw)
In-Reply-To: <20110328212015.GH30616@atomide.com>
Hi,
>-----Original Message-----
>From: Tony Lindgren [mailto:tony@atomide.com]
>Sent: Tuesday, March 29, 2011 2:50 AM
>To: Hema HK
>Cc: linux-usb@vger.kernel.org; linux-omap@vger.kernel.org
>Subject: Re: [PATCH 1/2 v2] usb: otg: OMAP4430: Fixing the
>omap4430_phy_init function
>
>* Hema HK <hemahk@ti.com> [110324 04:36]:
>> omap4430_phy_init() function can be called with no device pointer,
>> to powerdown the PHY during board init when USB is disabled.
>> Fix the function accordingly.
>
>This should no longer be needed after merge commit
>0df0914d414a504b975f3cc66ace0c16ef55b7f3.
I did not get how the above commit help to fix it.
This fix is required in the USB disabled case.
When CONFIG_USB is not enabled, then the device is not built
but, there is a need to powerdown the PHY for core domain transition to
ret and offmode.
Regards,
Hema
>
>Tony
>
next prev parent reply other threads:[~2011-03-29 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 11:38 [PATCH 1/2 v2] usb: otg: OMAP4430: Fixing the omap4430_phy_init function Hema HK
[not found] ` <1300966722-10955-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
2011-03-28 21:20 ` Tony Lindgren
2011-03-29 6:13 ` Hema Kalliguddi [this message]
2011-03-30 18:46 ` Tony Lindgren
2011-03-31 7:03 ` Hema Kalliguddi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4369479157892165533add3d883a79a7@mail.gmail.com \
--to=hemahk@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).