public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix AUDIO_MCBSP_DATAREAD/WRITE undefined for OMAP16xx
@ 2006-01-17 18:44 Dirk Behme
  2006-01-17 19:21 ` lamikr
  0 siblings, 1 reply; 3+ messages in thread
From: Dirk Behme @ 2006-01-17 18:44 UTC (permalink / raw)
  To: linux-omap-open-source

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]


ARM: OMAP: Define AUDIO_MCBSP_DATAREAD/WRITE for OMAP16xx as well

Fix error

sound/oss/omap-audio-dma-intfc.c:715: error: `AUDIO_MCBSP_DATAWRITE'
undeclared (first use in this function)
sound/oss/omap-audio-dma-intfc.c:745: error: `AUDIO_MCBSP_DATAREAD'
undeclared (first use in this function)

Signed-off-by: Dirk Behme <dirk.behme_at_de.bosch.com>


[-- Attachment #2: audio_mcbsp_readwrite.patch --]
[-- Type: text/plain, Size: 406 bytes --]

--- ./include/asm-arm/arch-omap/mcbsp.h_orig	2006-01-17 18:34:46.000000000 +0100
+++ ./include/asm-arm/arch-omap/mcbsp.h	2006-01-17 18:37:11.720163080 +0100
@@ -80,6 +80,9 @@
 #define AUDIO_DMA_TX		OMAP_DMA_MCBSP1_TX
 #define AUDIO_DMA_RX		OMAP_DMA_MCBSP1_RX
 
+#define AUDIO_MCBSP_DATAWRITE	(0)
+#define AUDIO_MCBSP_DATAREAD	(0)
+
 #elif defined(CONFIG_ARCH_OMAP24XX)
 
 #define OMAP_MCBSP_REG_DRR2	0x00


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix AUDIO_MCBSP_DATAREAD/WRITE undefined for OMAP16xx
  2006-01-17 18:44 [PATCH] Fix AUDIO_MCBSP_DATAREAD/WRITE undefined for OMAP16xx Dirk Behme
@ 2006-01-17 19:21 ` lamikr
  2006-01-19 20:05   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: lamikr @ 2006-01-17 19:21 UTC (permalink / raw)
  To: linux-omap-open-source

For this I think it would be better to take the patch from the message
titled "omap1510/16xx fixes for the tsc2101 oss driver" I send yesterday.
It defines the AUDIO_MCBSP_DATAWRITE and AUDIO_MCBSP_DATAREAD for the
omap1510/16xx in a similar way than is done for the omap24xx.

Mika

Dirk Behme wrote:

>
> ARM: OMAP: Define AUDIO_MCBSP_DATAREAD/WRITE for OMAP16xx as well
>
> Fix error
>
> sound/oss/omap-audio-dma-intfc.c:715: error: `AUDIO_MCBSP_DATAWRITE'
> undeclared (first use in this function)
> sound/oss/omap-audio-dma-intfc.c:745: error: `AUDIO_MCBSP_DATAREAD'
> undeclared (first use in this function)
>
> Signed-off-by: Dirk Behme <dirk.behme_at_de.bosch.com>
>
>------------------------------------------------------------------------
>
>--- ./include/asm-arm/arch-omap/mcbsp.h_orig	2006-01-17 18:34:46.000000000 +0100
>+++ ./include/asm-arm/arch-omap/mcbsp.h	2006-01-17 18:37:11.720163080 +0100
>@@ -80,6 +80,9 @@
> #define AUDIO_DMA_TX		OMAP_DMA_MCBSP1_TX
> #define AUDIO_DMA_RX		OMAP_DMA_MCBSP1_RX
> 
>+#define AUDIO_MCBSP_DATAWRITE	(0)
>+#define AUDIO_MCBSP_DATAREAD	(0)
>+
> #elif defined(CONFIG_ARCH_OMAP24XX)
> 
> #define OMAP_MCBSP_REG_DRR2	0x00
>
>  
>
>------------------------------------------------------------------------
>
>_______________________________________________
>Linux-omap-open-source mailing list
>Linux-omap-open-source@linux.omap.com
>http://linux.omap.com/mailman/listinfo/linux-omap-open-source
>  
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix AUDIO_MCBSP_DATAREAD/WRITE undefined for OMAP16xx
  2006-01-17 19:21 ` lamikr
@ 2006-01-19 20:05   ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2006-01-19 20:05 UTC (permalink / raw)
  To: linux-omap-open-source

* lamikr <lamikr@cc.jyu.fi> [060117 13:47]:
> For this I think it would be better to take the patch from the message
> titled "omap1510/16xx fixes for the tsc2101 oss driver" I send yesterday.
> It defines the AUDIO_MCBSP_DATAWRITE and AUDIO_MCBSP_DATAREAD for the
> omap1510/16xx in a similar way than is done for the omap24xx.
> 
> Mika
> 
> Dirk Behme wrote:
> 
> >
> > ARM: OMAP: Define AUDIO_MCBSP_DATAREAD/WRITE for OMAP16xx as well
> >
> > Fix error
> >
> > sound/oss/omap-audio-dma-intfc.c:715: error: `AUDIO_MCBSP_DATAWRITE'
> > undeclared (first use in this function)
> > sound/oss/omap-audio-dma-intfc.c:745: error: `AUDIO_MCBSP_DATAREAD'
> > undeclared (first use in this function)
> >
> > Signed-off-by: Dirk Behme <dirk.behme_at_de.bosch.com>
> >
> >------------------------------------------------------------------------
> >
> >--- ./include/asm-arm/arch-omap/mcbsp.h_orig	2006-01-17 18:34:46.000000000 +0100
> >+++ ./include/asm-arm/arch-omap/mcbsp.h	2006-01-17 18:37:11.720163080 +0100
> >@@ -80,6 +80,9 @@
> > #define AUDIO_DMA_TX		OMAP_DMA_MCBSP1_TX
> > #define AUDIO_DMA_RX		OMAP_DMA_MCBSP1_RX
> > 
> >+#define AUDIO_MCBSP_DATAWRITE	(0)
> >+#define AUDIO_MCBSP_DATAREAD	(0)
> >+
> > #elif defined(CONFIG_ARCH_OMAP24XX)
> > 
> > #define OMAP_MCBSP_REG_DRR2	0x00

I'll push Mika's patch at some point today as it also include this one.

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-01-19 20:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-17 18:44 [PATCH] Fix AUDIO_MCBSP_DATAREAD/WRITE undefined for OMAP16xx Dirk Behme
2006-01-17 19:21 ` lamikr
2006-01-19 20:05   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox