From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD1CC388F9 for ; Wed, 11 Nov 2020 12:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCD2020709 for ; Wed, 11 Nov 2020 12:36:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="cSVbO9Eg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726216AbgKKMgR (ORCPT ); Wed, 11 Nov 2020 07:36:17 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:47806 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbgKKMgQ (ORCPT ); Wed, 11 Nov 2020 07:36:16 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0ABCa5hW058613; Wed, 11 Nov 2020 06:36:05 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1605098165; bh=jZlmvwEMi8kn6+Z5HsjZATByRRO93RiscNhbEWmYCIY=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=cSVbO9Eg4y3Kw+kit/T26PbpZ23oddpLU113/5NYJItE7ntU/R0gwAbW9aWfpfIQw hKvorulAGr7nwZ/PygWGVlH+fYSpjR69G0S69S7MQc0SMhRBS1lDP54AJ0koDRv5zc UVxwsBODGY2Jmr6G28jl4KUCMPKXtJtPijGr9gvo= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0ABCa5I0127832 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Nov 2020 06:36:05 -0600 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 11 Nov 2020 06:36:05 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 11 Nov 2020 06:36:05 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0ABCa3Rk112340; Wed, 11 Nov 2020 06:36:03 -0600 Subject: Re: [PATCH v3 35/56] drm/omap: dsi: implement check timings To: Laurent Pinchart CC: Sebastian Reichel , Nikhil Devshatwar , , , Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" , Sebastian Reichel References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-36-tomi.valkeinen@ti.com> <20201109104756.GF6029@pendragon.ideasonboard.com> From: Tomi Valkeinen Message-ID: <4432ea22-cf95-d207-2f87-0e105429cba1@ti.com> Date: Wed, 11 Nov 2020 14:36:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201109104756.GF6029@pendragon.ideasonboard.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 09/11/2020 12:47, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:03:12PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> Implement check timings, which will check if its possible to > > s/its/it's/ > >> configure the clocks for the provided mode using the same code >> as the set_config() hook. >> >> Signed-off-by: Sebastian Reichel >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/omapdrm/dss/dsi.c | 70 +++++++++++++++++++------------ >> 1 file changed, 44 insertions(+), 26 deletions(-) >> >> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c >> index a1a867a7d91d..f643321434e9 100644 >> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c >> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c >> @@ -280,6 +280,11 @@ struct dsi_isr_tables { >> struct dsi_isr_data isr_table_cio[DSI_MAX_NR_ISRS]; >> }; >> >> +struct dsi_lp_clock_info { >> + unsigned long lp_clk; >> + u16 lp_clk_div; >> +}; >> + >> struct dsi_clk_calc_ctx { >> struct dsi_data *dsi; >> struct dss_pll *pll; >> @@ -294,16 +299,12 @@ struct dsi_clk_calc_ctx { >> >> struct dss_pll_clock_info dsi_cinfo; >> struct dispc_clock_info dispc_cinfo; >> + struct dsi_lp_clock_info user_lp_cinfo; > > Any reason for the user_ prefix here ? No, I'll drop it. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki