From: Dirk Behme <dirk.behme@googlemail.com>
To: Paul Mundt <paul.mundt@nokia.com>, linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] Convert OSS aic23 to mutex
Date: Thu, 06 Apr 2006 16:45:00 +0200 [thread overview]
Message-ID: <4435296C.5040304@gmail.com> (raw)
In-Reply-To: <20060405190013.GA5532@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
Paul Mundt wrote:
> Are you sure this doesn't need an #include <linux/mutex.h>? All of the
> other conversions so far have..
It compiles without extra linux/mutex.h because
linux/sound.h includes linux/fs.h which includes
linux/mutex.h. But you are right, include linux/mutex.h is
cleaner. Please find updated patch in attachment.
Cheers
Dirk
ARM: OMAP: Convert OSS aic23 to mutex.
Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
[-- Attachment #2: omap-audio-aic23_mutex_patch.txt --]
[-- Type: text/plain, Size: 692 bytes --]
--- ./sound/oss/omap-audio-aic23.c_orig 2006-04-05 20:02:22.000000000 +0200
+++ ./sound/oss/omap-audio-aic23.c 2006-04-06 16:23:30.000000000 +0200
@@ -38,6 +38,7 @@
#include <linux/sound.h>
#include <linux/soundcard.h>
#include <linux/clk.h>
+#include <linux/mutex.h>
#include <asm/uaccess.h>
#include <asm/hardware.h>
@@ -243,7 +244,7 @@ static audio_state_t aic23_state = {
.hw_remove = __exit_p(omap_aic23_remove),
.hw_suspend = omap_aic23_suspend,
.hw_resume = omap_aic23_resume,
- .sem = __SEMAPHORE_INIT(aic23_state.sem, 1),
+ .mutex = __MUTEX_INITIALIZER(aic23_state.mutex),
};
/* This will be defined in the audio.h */
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2006-04-06 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 18:10 [PATCH] Convert OSS aic23 to mutex Dirk Behme
2006-04-05 19:00 ` Paul Mundt
2006-04-06 14:45 ` Dirk Behme [this message]
2006-04-28 10:29 ` tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4435296C.5040304@gmail.com \
--to=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=paul.mundt@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox