From: Kevin Hilman <khilman@mvista.com>
To: tglx@linutronix.de
Cc: linux-omap-open-source@linux.omap.com,
LAK <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH 00/32] Convert ARM to generic irq subsystem
Date: Fri, 28 Apr 2006 16:17:22 -0700 [thread overview]
Message-ID: <4452A282.4050909@mvista.com> (raw)
In-Reply-To: <1146263927.1322.640.camel@localhost.localdomain>
Thomas Gleixner wrote:
> On Fri, 2006-04-28 at 15:07 -0700, Kevin Hilman wrote:
>> R am testing these on OMAP.
>>
>> First pass shows that smc91x interrupts are getting lost. They are GPIO
>> interrupts on most OMAP platforms and pass through a chained gpio handler. I'm
>> still investigating, but I'm guessing it as something to do with SA_TRIGGER_*
>> flags used in the smc91x driver for OMAP.
>>
>> I don't see handling of SA_TRIGGER_* in the generic layer. Is there a new way
>> of handling these?
>
> No. That chunk got lost unfortunately. Can you retry with the new patch
> against -rc3 please ?
>
> http://www.tglx.de/projects/armirq/2.6.17-rc3/patch-2.6.17-rc3-armirq1.patches.tar.bz2
>
ok, I tried with -rc3 and I still dont see any GPIO interrupts.
After looking closer at the IRQ_TYPE_* flags, I noticed that they didn't match
the SA_TRIGGER_* flags for _FALLING or _RISING. The following patch swaps the
two and make OMAP happy. It's now booting, and things seem sane. Will do some
more intensive testing
Kevin
Index: linux-omap-2.6/include/linux/irq.h
===================================================================
--- linux-omap-2.6.orig/include/linux/irq.h
+++ linux-omap-2.6/include/linux/irq.h
@@ -39,8 +39,8 @@
* IRQ types, see also include/linux/interrupt.h
*/
#define IRQ_TYPE_NONE 0x0000 /* Default, unspecified type */
-#define IRQ_TYPE_EDGE_FALLING 0x0001 /* Edge falling type */
-#define IRQ_TYPE_EDGE_RISING 0x0002 /* Edge rising type */
+#define IRQ_TYPE_EDGE_RISING 0x0001 /* Edge rising type */
+#define IRQ_TYPE_EDGE_FALLING 0x0002 /* Edge falling type */
#define IRQ_TYPE_EDGE_BOTH (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING)
#define IRQ_TYPE_LEVEL_HIGH 0x0004 /* Level high type */
#define IRQ_TYPE_LEVEL_LOW 0x0008 /* Level low type */
next prev parent reply other threads:[~2006-04-28 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060407095850.690110000@localhost.localdomain>
[not found] ` <20060426230543.GA28908@flint.arm.linux.org.uk>
2006-04-28 22:07 ` [PATCH 00/32] Convert ARM to generic irq subsystem Kevin Hilman
2006-04-28 22:38 ` Thomas Gleixner
2006-04-28 23:17 ` Kevin Hilman [this message]
2006-04-29 10:08 ` Thomas Gleixner
2006-05-02 11:59 ` Tony Lindgren
2006-05-02 12:33 ` Thomas Gleixner
2006-05-02 18:18 ` Adam Brooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4452A282.4050909@mvista.com \
--to=khilman@mvista.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap-open-source@linux.omap.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox