public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap-open-source@linux.omap.com
Subject: Undefined usb_disconnect, was [PATCH] ARM: OMAP: Fix tlv320aic23.c
Date: Thu, 04 May 2006 18:08:50 +0200	[thread overview]
Message-ID: <445A2712.1000606@gmail.com> (raw)
In-Reply-To: <200605040751.45417.david-b@pacbell.net>

David Brownell wrote:
> On Wednesday 03 May 2006 11:41 am, Dirk Behme wrote:
> 
>>WARNING: "usb_disconnect" [drivers/usb/host/ohci-hcd.ko]
>>undefined!
> 
> Of course, it hasn't been exported for a while now.
>>
>>Any ideas about USB? Seems that it comes from
>>drivers/usb/host/ohci-omap.c
> 
> I see a curious and pointless routine, ohci_omap_host_enable(), which
> isn't called from anywhere I can see, which wants usb_disconnect().
> 
> Try deleting that routine.

tahvo-usb.c uses ohci_omap_host_enable():

./drivers/cbus/tahvo-usb.c:88:extern int 
ohci_omap_host_enable(struct usb_bus *host, int enable);
./drivers/cbus/tahvo-usb.c:248: 
ohci_omap_host_enable(tu->otg.host, 1);
./drivers/cbus/tahvo-usb.c:266: 
ohci_omap_host_enable(tu->otg.host, 0);
./drivers/cbus/tahvo-usb.c:300: 
ohci_omap_host_enable(tu->otg.host, 0);
./drivers/cbus/tahvo-usb.c:338: 
ohci_omap_host_enable(tu->otg.host, 0);
./drivers/cbus/tahvo-usb.c:431: ohci_omap_host_enable(host, 0);

Regards

Dirk

  reply	other threads:[~2006-05-04 16:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-28 15:44 [PATCH] ARM: OMAP: Fix tlv320aic23.c Dirk Behme
2006-05-03 12:56 ` Tony Lindgren
2006-05-03 18:41   ` Dirk Behme
2006-05-04 14:51     ` David Brownell
2006-05-04 16:08       ` Dirk Behme [this message]
2006-05-04 16:32         ` Undefined usb_disconnect, was " David Brownell
2006-05-05  4:50           ` Undefined usb_disconnect Dirk Behme
2006-05-05  8:08             ` Hiroshi DOYU
2006-05-27  6:38               ` Dirk Behme
2006-05-27 15:43                 ` David Brownell
2006-05-28 13:21                   ` Dirk Behme
2006-05-28 16:17                     ` David Brownell
2006-07-04  8:20                   ` tony
2006-05-03 19:42   ` [PATCH] ARM: OMAP: Fix tlv320aic23.c lamikr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=445A2712.1000606@gmail.com \
    --to=dirk.behme@googlemail.com \
    --cc=david-b@pacbell.net \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox