From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Subject: Re: Undefined usb_disconnect Date: Fri, 05 May 2006 06:50:11 +0200 Message-ID: <445AD983.7060908@gmail.com> References: <4452384E.7080409@gmail.com> <200605040751.45417.david-b@pacbell.net> <445A2712.1000606@gmail.com> <200605040932.46678.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200605040932.46678.david-b@pacbell.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org David Brownell wrote: > On Thursday 04 May 2006 9:08 am, Dirk Behme wrote: >>David Brownell wrote: >>>On Wednesday 03 May 2006 11:41 am, Dirk Behme wrote: >>>I see a curious and pointless routine, ohci_omap_host_enable(), which >>>isn't called from anywhere I can see, which wants usb_disconnect(). >>> >>>Try deleting that routine. >> >>tahvo-usb.c uses ohci_omap_host_enable(): > > And so it does. That would be a bug in how the Tahvo transceiver is > trying to activate the USB host. It should be able to just use > the normal power management suspend and resume calls... certainly > there's no benefit to creating transceiver-specific backdoors into > usbcore for runtime PM. Anybody like to fix and test tahvo-usb.c regarding this? Then we could remove ohci_omap_host_enable() from drivers/usb/host/ohci-omap.c . Cheers Dirk