[PATCH] ARM: OMAP: OMAP_GPIO_SWITCH doesn't need OMAP_BOOT_TAG

[PATCH] ARM: OMAP: OMAP_GPIO_SWITCH doesn't need OMAP_BOOT_TAG

[Jonathan McDowell]

I can't see any reason why OMAP_GPIO_SWITCH depends on OMAP_BOOT_TAG;
it compiles fine without it. This patch removes the Kconfig dependency.

Also the description is wrong; it doesn't hook into the input layer at
all from what I can tell. Are there patches around that add this? The
Amstrad Delta has a phone hook on a GPIO that I plan to support with
this driver and being able to produce a keypress would be nice.

Signed-off-by: Jonathan McDowell <noodles@earth.li>

-----
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index 28ca5ad..762d417 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -57,13 +57,12 @@ config OMAP_COMPONENT_VERSION
 
 config OMAP_GPIO_SWITCH
 	bool "GPIO switch support"
-        depends on OMAP_BOOT_TAG
         default n
         help
           Say Y, if you want to have support for input layer reporting
           of GPIO switches (e.g. cover switches). Your bootloader has to
           provide information about the switches to the kernel via the
-          ATAG_BOARD mechanism.
+          ATAG_BOARD mechanism if they're not defined by the board config.
 
 config OMAP_MUX
 	bool "OMAP multiplexing support"
-----

J.

-- 
Web [    I'd love to but... I'm having all my plants neutered.     ]
site: http:// [                                          ]       Made by
www.earth.li/~noodles/  [                      ]         HuggieTag 0.0.23

Re: [PATCH] ARM: OMAP: OMAP_GPIO_SWITCH doesn't need OMAP_BOOT_TAG

[Paul Mundt]

On Wed, May 17, 2006 at 06:25:47PM +0100, Jonathan McDowell wrote:
> I can't see any reason why OMAP_GPIO_SWITCH depends on OMAP_BOOT_TAG;
> it compiles fine without it. This patch removes the Kconfig dependency.
> 
It doesn't depend on it specifically itself, no, so I suppose dropping
the dependency is fine.

> Also the description is wrong; it doesn't hook into the input layer at
> all from what I can tell. Are there patches around that add this? The
> Amstrad Delta has a phone hook on a GPIO that I plan to support with
> this driver and being able to produce a keypress would be nice.
> 
May as well just remove 'input layer' from the description, it was a
legacy thing..

> Signed-off-by: Jonathan McDowell <noodles@earth.li>
> 
Acked-by: Paul Mundt <paul.mundt@nokia.com>

Re: [PATCH] ARM: OMAP: OMAP_GPIO_SWITCH doesn't need OMAP_BOOT_TAG

[Juha Yrjölä]

Jonathan McDowell wrote:

> I can't see any reason why OMAP_GPIO_SWITCH depends on OMAP_BOOT_TAG;
> it compiles fine without it. This patch removes the Kconfig dependency.

Yeah, that's a legacy restriction.

> Also the description is wrong; it doesn't hook into the input layer at
> all from what I can tell. Are there patches around that add this? The
> Amstrad Delta has a phone hook on a GPIO that I plan to support with
> this driver and being able to produce a keypress would be nice.

It doesn't anymore.  We replaced that with uevents.  Nowadays the right 
way to go is to use the sysfs_notify() API.

The patches for the input stuff are probably long gone (but you might 
find something in the BitKeeper repository).  I won't object to someone 
re-adding the input layer functionality again, though.

Cheers,
Juha

[PATCH] ARM: OMAP: OMAP_GPIO_SWITCH doesn't need OMAP_BOOT_TAG

[Jonathan McDowell]

On Wed, May 17, 2006 at 06:25:47PM +0100, Jonathan McDowell wrote:
> I can't see any reason why OMAP_GPIO_SWITCH depends on OMAP_BOOT_TAG;
> it compiles fine without it. This patch removes the Kconfig dependency.

Here's an updated patch that not only removes the dependency but cleans
up the Kconfig description to talk about sysfs rather than the input
layer.

Signed-off-by: Jonathan McDowell <noodles@earth.li>

-----
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index 28ca5ad..cc8c793 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -57,13 +57,12 @@ config OMAP_COMPONENT_VERSION
 
 config OMAP_GPIO_SWITCH
 	bool "GPIO switch support"
-        depends on OMAP_BOOT_TAG
         default n
         help
-          Say Y, if you want to have support for input layer reporting
-          of GPIO switches (e.g. cover switches). Your bootloader has to
-          provide information about the switches to the kernel via the
-          ATAG_BOARD mechanism.
+          Say Y, if you want to have support for reporting of GPIO
+          switches (e.g. cover switches) via sysfs. Your bootloader has
+          to provide information about the switches to the kernel via the
+          ATAG_BOARD mechanism if they're not defined by the board config.
 
 config OMAP_MUX
 	bool "OMAP multiplexing support"
-----

J.

-- 
                                            jid: noodles@jabber.earth.li
Three can keep a secret, if two are dead.

Re: [PATCH] ARM: OMAP: OMAP_GPIO_SWITCH doesn't need OMAP_BOOT_TAG

[Tony Lindgren]

* Jonathan McDowell <noodles@earth.li> [060518 02:19]:
> On Wed, May 17, 2006 at 06:25:47PM +0100, Jonathan McDowell wrote:
> > I can't see any reason why OMAP_GPIO_SWITCH depends on OMAP_BOOT_TAG;
> > it compiles fine without it. This patch removes the Kconfig dependency.
> 
> Here's an updated patch that not only removes the dependency but cleans
> up the Kconfig description to talk about sysfs rather than the input
> layer.
> 
> Signed-off-by: Jonathan McDowell <noodles@earth.li>
> 
> -----
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index 28ca5ad..cc8c793 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -57,13 +57,12 @@ config OMAP_COMPONENT_VERSION
>  
>  config OMAP_GPIO_SWITCH
>  	bool "GPIO switch support"
> -        depends on OMAP_BOOT_TAG
>          default n
>          help
> -          Say Y, if you want to have support for input layer reporting
> -          of GPIO switches (e.g. cover switches). Your bootloader has to
> -          provide information about the switches to the kernel via the
> -          ATAG_BOARD mechanism.
> +          Say Y, if you want to have support for reporting of GPIO
> +          switches (e.g. cover switches) via sysfs. Your bootloader has
> +          to provide information about the switches to the kernel via the
> +          ATAG_BOARD mechanism if they're not defined by the board config.
>  
>  config OMAP_MUX
>  	bool "OMAP multiplexing support"

Pushing today. This allows us also to integrate the gpio switch into the
mainline kernel.

Tony