Re: [PATCH] input: ads7846: can't disable filtering [was OMAP5912 touchscreen irq not working]

David Brownell
2006-06-05T15:17:13Z

On Monday 05 June 2006 7:29 am, Imre Deak wrote:
>
> The solution would be to use the IRQ line state - as we already do to
> determine the pen down - for the pen up event as well.
> ...
> > Sorry, but at least on OSK with Mistral this new stuff isn't
> > usable. Old driver worked quite well.
>
> Yes, I checked the old driver and it uses the pen IRQ for pen down / up
> events, so that might be the difference.

Well, there have been recent regressions, but the new code _has_ worked
quite well in the past ...

Using the pen IRQ for driver state transitions is problematic, since the
driver has to work with a variety of triggering modes ... both edges,
falling only (or, with hw inverter, rising only), low level (or, with
inverter, high).

It's true that having that "poll penirq state" method is a big win.

- Dave