Re: [PATCH] ARM: OMAP: Add minimal OMAP2430 support

Komal Shah
2006-06-12T06:43:09Z

--- Juha Yrjölä <juha.yrjola@solidboot.com> wrote:

>
> Exactly. That's why I keep my read_reg/write_reg functions static.
> Usually I put even the register definitions to the .c file, since
> other
> drivers shouldn't have any business modifying them directly anyway.
>

Have them static prcm_read/write_reg means, that clock.c and prcm.c
should be merged, as clock.c is the heaviest user of PRCM/CM_*
registers as of now, and only having static prcm_read/write_reg
functions in prcm.c doesn't solve usage PRCM_* registers from clock.c?

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around