Re: [PATCH] ARM: OMAP: Add minimal OMAP2430 support

Juha Yrjölä
2006-06-11T13:54:23Z

Woodruff, Richard wrote:

> Along with my other biases I rationalized it this way... I like
> having a private driver incompatible method to access the PRCM. It forces
> drivers to use API access functions and not directly access its
> registers. The PRCM has more and more things to manage and having some
> xyz driver mess up its state behind my back will break everything.

Exactly. That's why I keep my read_reg/write_reg functions static.
Usually I put even the register definitions to the .c file, since other
drivers shouldn't have any business modifying them directly anyway.

Cheers,
Juha