Re: [PATCH] ARM: OMAP: Add minimal OMAP2430 support

Tony Lindgren
2006-06-12T16:07:46Z

* Komal Shah <komal_shah802003@yahoo.com> [060611 23:45]:
> --- Juha Yrjölä <juha.yrjola@solidboot.com> wrote:
>
> >
> > Exactly. That's why I keep my read_reg/write_reg functions static.
> > Usually I put even the register definitions to the .c file, since
> > other
> > drivers shouldn't have any business modifying them directly anyway.
> >
>
> Have them static prcm_read/write_reg means, that clock.c and prcm.c
> should be merged, as clock.c is the heaviest user of PRCM/CM_*
> registers as of now, and only having static prcm_read/write_reg
> functions in prcm.c doesn't solve usage PRCM_* registers from clock.c?

Or put clock related PRCM registers to clock.c, power domain related
registers to pm-domain.c and so on. I have pm-domain.c somewhat ready
here and will push it as soon as I can.

Regards,

Tony