From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Juha_Yrj=F6l=E4?= Subject: Re: [PATCH] ARM: OMAP: Add minimal OMAP2430 support Date: Sun, 11 Jun 2006 16:54:23 +0300 Message-ID: <448C208F.4020102@solidboot.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: "Woodruff, Richard" Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org Woodruff, Richard wrote: > Along with my other biases I rationalized it this way... I like > having a private driver incompatible method to access the PRCM. It forces > drivers to use API access functions and not directly access its > registers. The PRCM has more and more things to manage and having some > xyz driver mess up its state behind my back will break everything. Exactly. That's why I keep my read_reg/write_reg functions static. Usually I put even the register definitions to the .c file, since other drivers shouldn't have any business modifying them directly anyway. Cheers, Juha