public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP: Fix missing channel using omap_set_dma_priority()
@ 2006-07-04 14:45 Dirk Behme
  0 siblings, 0 replies; only message in thread
From: Dirk Behme @ 2006-07-04 14:45 UTC (permalink / raw)
  To: linux-omap-open-source

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]


ARM: OMAP: Fix missing channel parameter using
omap_set_dma_priority() in omapfb_main.c:

drivers/video/omap/omapfb_main.c: In function 'omapfb_do_probe':
drivers/video/omap/omapfb_main.c:1441: error: too few
arguments to function
         'omap_set_dma_priority'

omap_set_dma_priority() in dma.c wants a channel as first
parameter which is missing here. However, this is only used
on OMAP24xx, on OMAP1 it isn't. Therefore I don't know if 0
is correct here, it's
don't care for OMAP1. Please check.

Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>

[-- Attachment #2: dma_priority_workaround_patch.txt --]
[-- Type: text/plain, Size: 503 bytes --]

--- ./drivers/video/omap/omapfb_main.c_orig	2006-07-04 16:28:26.000000000 +0200
+++ ./drivers/video/omap/omapfb_main.c	2006-07-04 16:34:25.000000000 +0200
@@ -1438,7 +1438,7 @@ static int omapfb_do_probe(struct platfo
 #ifdef CONFIG_FB_OMAP_DMA_TUNE
 	/* Set DMA priority for EMIFF access to highest */
 	if (cpu_class_is_omap1())
-		omap_set_dma_priority(OMAP_DMA_PORT_EMIFF, 15);
+	        omap_set_dma_priority(0, OMAP_DMA_PORT_EMIFF, 15);
 #endif
 
 	r = ctrl_change_mode(fbdev->fb_info[0]);








[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-07-04 14:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-04 14:45 [PATCH] ARM: OMAP: Fix missing channel using omap_set_dma_priority() Dirk Behme

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox