status of OMAP ALSA support

status of OMAP ALSA support

[Zhang, Jian]

Hi,

Does OMAP ALSA driver work? Neither H4 nor H3 has it in default
configuration.  

I see the following in tsc2101 codec driver:

codec_cfg = pdev->dev.platform_data;
if (codec_cfg != NULL) {
 ...
}
else
ret = -ENODEV;

I don't see any code to set up dev.platform_data. As a result, codec_cfg
is always NULL and OMAP ALSA should not work at all. 

I might miss something here. Please comment.

Other than that, it seems to have the following limitations by looking
at the code statically.
- omap-alsa.c knows the codec connectivity detail (hard-coded to
MCBSP1). This file should be independent of board specifics.
- Dead lock as s->dma_lock is double locked in multiple locations.
- Don't support duplex as codec lock is shut off when either input
stream or output stream is closed.
- Memory strategy is very rudimental: Hard-coded to allocate 128KB
consistent memory in init time.   

Regards,
Jian

Re: status of OMAP ALSA support

[lamikr]

Zhang, Jian wrote:
> Hi,
>
> Does OMAP ALSA driver work? Neither H4 nor H3 has it in default
> configuration.
>   
Yes, the aic23 has been tested with board-osk and tsc2101 has been tested
with the board-osk and board-h6300. (h6300 specific code is not yet send
to omap-kernel list,
but you can check the h6300 port of omap 2.6.16 kernel it by using command:
svn export svn://fuzzyneural.net/h6300/omap-linux/branches/h6300_dev

> I see the following in tsc2101 codec driver:
>
> codec_cfg = pdev->dev.platform_data;
> if (codec_cfg != NULL) {
>  ...
> }
> else
> ret = -ENODEV;
>
> I don't see any code to set up dev.platform_data. As a result, codec_cfg
> is always NULL and OMAP ALSA should not work at all. 
>   
It should be pretty easy to add the support also for other omap boards
if you
just know the correct MCBSP settings. I have not access to h3 or h4
boards so
I have not been able to test them. Do you have access to that data?

I have however send once the patches adding a similar kind of support
for the Innovator and 770 boards that are using aic23 chipset.
Innovator patches has been tested to work by James Selvam.

According to one message in maemo developer list, somebody build &
tested also the 770 patch and was able to hear some kind of noice but
not correct sound.
(mcbsp settings were probably incorrect for that board). It seems that
n770 uses anyway some other driver for the sounds by default, so I have
not investigated this further.

> I might miss something here. Please comment.
>
> Other than that, it seems to have the following limitations by looking
> at the code statically.
> - omap-alsa.c knows the codec connectivity detail (hard-coded to
> MCBSP1). This file should be independent of board specifics.
>   
Maybe that info could also be set-up either during the kernel
configuration phase or in board-file.
> - Dead lock as s->dma_lock is double locked in multiple locations.
>   
Hmm, I have not noticed any dead locks. With my h6300 I need however
stop sound dma in every round in audio_process_dma() function.
(and according to innovator tests by James Selvam, other omap1510
devices needs to do also the same)

> - Don't support duplex as codec lock is shut off when either input
> stream or output stream is closed.
>   
Do you have any patches for these? If you want I could also try to work
with you to fix these issues.
> - Memory strategy is very rudimental: Hard-coded to allocate 128KB
> consistent memory in init time.
>   
Would you like to specify this also in the board file?

Mika

RE: status of OMAP ALSA support

[Zhang, Jian]

Mika,

Thanks for the response. I have overlooked this email until today.

Good to know it is tested on H2. I should be able to get a H2. I tried
to build a H3 kernel with tsc2101 codec. The alsa core reported no sound
card. It seems that snd_card_new() fails silently in omap alsa core. 

I don't have any fixes yet. I can add H3/H4 support once I first have it
run on H2 (I am new to sound so need some tracing of control flow:)) The
current focus is to understand ALSA. I have asked you a dummy
configuration question in a separate email. Any help from you is
appreciated.   

Will work with you once I am on the way.

Regards,
Jian

-----Original Message-----
From: linux-omap-open-source-bounces@linux.omap.com
[mailto:linux-omap-open-source-bounces@linux.omap.com] On Behalf Of
lamikr
Sent: Wednesday, August 09, 2006 7:42 PM
To: Zhang, Jian
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: status of OMAP ALSA support

Zhang, Jian wrote:
> Hi,
>
> Does OMAP ALSA driver work? Neither H4 nor H3 has it in default
> configuration.
>   
Yes, the aic23 has been tested with board-osk and tsc2101 has been
tested
with the board-osk and board-h6300. (h6300 specific code is not yet send
to omap-kernel list,
but you can check the h6300 port of omap 2.6.16 kernel it by using
command:
svn export svn://fuzzyneural.net/h6300/omap-linux/branches/h6300_dev

> I see the following in tsc2101 codec driver:
>
> codec_cfg = pdev->dev.platform_data;
> if (codec_cfg != NULL) {
>  ...
> }
> else
> ret = -ENODEV;
>
> I don't see any code to set up dev.platform_data. As a result,
codec_cfg
> is always NULL and OMAP ALSA should not work at all. 
>   
It should be pretty easy to add the support also for other omap boards
if you
just know the correct MCBSP settings. I have not access to h3 or h4
boards so
I have not been able to test them. Do you have access to that data?

I have however send once the patches adding a similar kind of support
for the Innovator and 770 boards that are using aic23 chipset.
Innovator patches has been tested to work by James Selvam.

According to one message in maemo developer list, somebody build &
tested also the 770 patch and was able to hear some kind of noice but
not correct sound.
(mcbsp settings were probably incorrect for that board). It seems that
n770 uses anyway some other driver for the sounds by default, so I have
not investigated this further.

> I might miss something here. Please comment.
>
> Other than that, it seems to have the following limitations by looking
> at the code statically.
> - omap-alsa.c knows the codec connectivity detail (hard-coded to
> MCBSP1). This file should be independent of board specifics.
>   
Maybe that info could also be set-up either during the kernel
configuration phase or in board-file.
> - Dead lock as s->dma_lock is double locked in multiple locations.
>   
Hmm, I have not noticed any dead locks. With my h6300 I need however
stop sound dma in every round in audio_process_dma() function.
(and according to innovator tests by James Selvam, other omap1510
devices needs to do also the same)

> - Don't support duplex as codec lock is shut off when either input
> stream or output stream is closed.
>   
Do you have any patches for these? If you want I could also try to work
with you to fix these issues.
> - Memory strategy is very rudimental: Hard-coded to allocate 128KB
> consistent memory in init time.
>   
Would you like to specify this also in the board file?

Mika
_______________________________________________
Linux-omap-open-source mailing list
Linux-omap-open-source@linux.omap.com
http://linux.omap.com/mailman/listinfo/linux-omap-open-source

RE: status of OMAP ALSA support

[Komal Shah]

--- "Zhang, Jian" <jzhang@ti.com> wrote:

> Mika,
> 
> Thanks for the response. I have overlooked this email until today.
> 
> Good to know it is tested on H2. I should be able to get a H2. I
> tried
> to build a H3 kernel with tsc2101 codec. The alsa core reported no
> sound
> card. It seems that snd_card_new() fails silently in omap alsa core. 
> 
> I don't have any fixes yet. I can add H3/H4 support once I first have
> it
> run on H2 (I am new to sound so need some tracing of control flow:))
> The
> current focus is to understand ALSA. I have asked you a dummy
> configuration question in a separate email. Any help from you is
> appreciated.   

And to make it work on H4, it is better to have tsc2101 protocol driver
understanding the current OMAP2-spi driver _or_ better if Juha releases
tsc2301 driver early, so that we can derive tsc2101 changes straight
from there ;) 

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com