From mboxrd@z Thu Jan 1 00:00:00 1970 From: lamikr Subject: Re: [PATCH] OMAP audio DMA changes for 310 CPUs Date: Fri, 18 Aug 2006 20:07:26 +0300 Message-ID: <44E5F3CE.3010501@cc.jyu.fi> References: Reply-To: lamikr@cc.jyu.fi Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: balrogg@gmail.com Cc: Linux-OMAP List-Id: linux-omap@vger.kernel.org Hi andrzej I have couple of questions from your patch. Your patch has couple of these changes where cpu_is_omap1510() has been changed to cpu_is_omap15xx(). - if (!cpu_is_omap1510()) + if (!cpu_is_omap15xx()) Do they affect to the sound in omap 310? (I mean is cpu_is_omap15xx() true for your omap310) Or is following the only relevant omap310 specific change + } else if (cpu_is_omap310()) + omap_start_dma(channel); Btw, your patch will not apply on top of all 5 patches I sent. Could you perhaps re-send it one more time? (I need also test whether your changes could work with omap1510/h6300) Mika andrzej zaborowski wrote: > Avoid restarting McBSP hardware after every DMA transfer to OMAP audio > devices on OMAP310, restart only DMA. Also avoid trying to link DMA > channels together as this feature isn't supported on 310 processors. > Apply on top of "[PATCH 1/5] Change all omap15xx devices to use > similar DMA handling than h6300 uses". > > Signed-off-by: Andrzej Zaborowski > ------------------------------------------------------------------------ > > _______________________________________________ > Linux-omap-open-source mailing list > Linux-omap-open-source@linux.omap.com > http://linux.omap.com/mailman/listinfo/linux-omap-open-source >