public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] OMAP3 Touchbook: Fix MMC caps
@ 2011-02-24 17:59 Radek (Mrkva) Pilař
  2011-02-24 19:34 ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Radek (Mrkva) Pilař @ 2011-02-24 17:59 UTC (permalink / raw)
  To: linux-omap

MMC controller cannot handle MMC_CAP_4_BIT_DATA nor MMC_CAP_8_BIT_DATA 
- the card won't be detected (tested with two SDHC cards, both Class6). 
Thus disabling.

Signed-off-by: Radek Pilar <mrkva@mrkva.eu>
---
 arch/arm/mach-omap2/board-omap3touchbook.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3touchbook.c 
b/arch/arm/mach-omap2/board-omap3touchbook.c
index 6a60f79..e65a32d 100644
--- a/arch/arm/mach-omap2/board-omap3touchbook.c
+++ b/arch/arm/mach-omap2/board-omap3touchbook.c
@@ -109,7 +109,6 @@ static struct omap_nand_platform_data 
omap3touchbook_nand_data = {
 static struct omap2_hsmmc_info mmc[] = {
 	{
 		.mmc		= 1,
-		.caps		= MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
 		.gpio_wp	= 29,
 	},
 	{}	/* Terminator */
--
1.7.4.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] OMAP3 Touchbook: Fix MMC caps
  2011-02-24 17:59 [PATCH 1/2] OMAP3 Touchbook: Fix MMC caps Radek (Mrkva) Pilař
@ 2011-02-24 19:34 ` Tony Lindgren
  2011-02-24 20:09   ` Radek (Mrkva) Pilař
  0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2011-02-24 19:34 UTC (permalink / raw)
  To: Radek (Mrkva) Pilař; +Cc: linux-omap

* Radek (Mrkva) Pilař <mrkva@mrkva.eu> [110224 10:02]:
> MMC controller cannot handle MMC_CAP_4_BIT_DATA nor
> MMC_CAP_8_BIT_DATA - the card won't be detected (tested with two
> SDHC cards, both Class6). Thus disabling.

Hmm it might be worth checking that the MMC data lines are muxed
correctly. Maybe make sure CONFIG_OMAP_MUX_DEBUG is set in
your .config and CONFIG_DEBUG_FS too. Then boot and and mount
debugfs with mount -tdebugfs debugfs /sys/kernel/debug.
Then you can do:

# grep -i mmc1 /sys/kernel/debug/omap_mux/* | grep dat

And check the settings. Changing the values could cause data
corruption, so use a temporary root file system!

Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] OMAP3 Touchbook: Fix MMC caps
  2011-02-24 19:34 ` Tony Lindgren
@ 2011-02-24 20:09   ` Radek (Mrkva) Pilař
  0 siblings, 0 replies; 3+ messages in thread
From: Radek (Mrkva) Pilař @ 2011-02-24 20:09 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap

Well, MMC_CAP_8BIT data is definetely wrong - according to schematics,
there are only D0-D3 (+CLK and CMD) lines connected. I'm going to test 4
BIT and let you know.

On Thu, 24 Feb 2011 11:34:42 -0800, Tony Lindgren <tony@atomide.com>
wrote:
> * Radek (Mrkva) Pilař <mrkva@mrkva.eu> [110224 10:02]:
>> MMC controller cannot handle MMC_CAP_4_BIT_DATA nor
>> MMC_CAP_8_BIT_DATA - the card won't be detected (tested with two
>> SDHC cards, both Class6). Thus disabling.
> 
> Hmm it might be worth checking that the MMC data lines are muxed
> correctly. Maybe make sure CONFIG_OMAP_MUX_DEBUG is set in
> your .config and CONFIG_DEBUG_FS too. Then boot and and mount
> debugfs with mount -tdebugfs debugfs /sys/kernel/debug.
> Then you can do:
> 
> # grep -i mmc1 /sys/kernel/debug/omap_mux/* | grep dat
> 
> And check the settings. Changing the values could cause data
> corruption, so use a temporary root file system!
> 
> Tony
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-02-24 20:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-24 17:59 [PATCH 1/2] OMAP3 Touchbook: Fix MMC caps Radek (Mrkva) Pilař
2011-02-24 19:34 ` Tony Lindgren
2011-02-24 20:09   ` Radek (Mrkva) Pilař

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox