RE: [PATCH/RFC 2/2] OMAP: PM: implement context loss count APIs

Vishwanath Sripathy
2010-12-11T07:13:26Z

Kevin,

> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> Sent: Saturday, December 11, 2010 6:14 AM
> To: Vishwanath Sripathy
> Cc: linux-omap@vger.kernel.org; Paul Walmsely
> Subject: Re: [PATCH/RFC 2/2] OMAP: PM: implement context loss count
> APIs
>
> Vishwanath Sripathy <vishwanath.bs@ti.com> writes:
>
> > Kevin,
> [...]
>
> >> @@ -288,20 +290,19 @@ unsigned long
> omap_pm_cpu_get_freq(void)
> >>
> >> int omap_pm_get_dev_context_loss_count(struct device *dev)
> >> {
> >> + struct platform_device *pdev = to_platform_device(dev);
> >> + int count;
> >> +
> >> if (!dev) {
> >> WARN_ON(1);
> >> return -EINVAL;
> >> };
> >>
> >> - pr_debug("OMAP PM: returning context loss count for dev %s\n",
> >> - dev_name(dev));
> >> + count = omap_device_get_context_loss_count(pdev);
> >> + pr_debug("OMAP PM: context loss count for dev %s = %d\n",
> >> + dev_name(dev), count);
> >
> > Shouldn't this implementation be part of omap-pm.c where all the
> OMAP PM
> > functions are to be implemented?
>
> Where is omap-pm.c?
It's not present and needs to be added. This file is anyway required for
adding device latency constraints as well.

Vishwa
>
> Kevin