RE: [PATCH/RFC 2/2] OMAP: PM: implement context loss count APIs

Paul Walmsley
2010-12-13T19:39:28Z

Vishwa

On Mon, 13 Dec 2010, Vishwanath Sripathy wrote:

> I have no issues with the implementation and I agree. All I am saying is
> that why can't this implementation be added in omap-pm.c and compile
> this file instead of omap-pm-noop.c

1. because omap-pm-noop.c needs to not actively break anything when it is
used, and this function, unlike most of the other functions in
omap-pm-noop.c, has no valid 'no-op' failure mode; and

2. because no one has yet posted a complete, clean, working,
SRF-free OMAP PM layer to the lists. It was the hope several years ago
when this interface was created that someone else would be capable of
doing this.

> when OMAP_PM is enabled.

What is this OMAP_PM that you are referring to?

> I believe this function is useful when off mode is enabled which means
> OMAP_PM is enabled.

Huh? Mainline Linux on OMAP can enter off-mode with omap2plus_defconfig
right now via a runtime debugfs setting. There is no KConfig setting to
enable.

- Paul