public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP: Fix warning in mach-omap1
@ 2006-10-27 16:19 Dirk Behme
  0 siblings, 0 replies; 3+ messages in thread
From: Dirk Behme @ 2006-10-27 16:19 UTC (permalink / raw)
  To: linux-omap-open-source

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

Fix warning

arch/arm/mach-omap1/pm.c: In function 'omap_pm_init':
arch/arm/mach-omap1/pm.c:765: warning: ignoring return value
of 'subsys_create_file', declared with attribute
warn_unused_result

Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>


[-- Attachment #2: mach_omap1_warn_patch.txt --]
[-- Type: text/plain, Size: 834 bytes --]

Index: linux-osk/arch/arm/mach-omap1/pm.c
===================================================================
--- linux-osk.orig/arch/arm/mach-omap1/pm.c
+++ linux-osk/arch/arm/mach-omap1/pm.c
@@ -706,6 +706,8 @@ static struct pm_ops omap_pm_ops ={
 
 static int __init omap_pm_init(void)
 {
+	int error = 0;
+
 	printk("Power Management for TI OMAP.\n");
 
 	/*
@@ -762,13 +764,15 @@ static int __init omap_pm_init(void)
 	omap_pm_init_proc();
 #endif
 
-	subsys_create_file(&power_subsys, &sleep_while_idle_attr);
+	error = subsys_create_file(&power_subsys, &sleep_while_idle_attr);
+	if(unlikely(error != 0))
+		printk(KERN_ERR "subsys_create_file failed: %d\n", error);
 
 	if (cpu_is_omap16xx()) {
 		/* configure LOW_PWR pin */
 		omap_cfg_reg(T20_1610_LOW_PWR);
 	}
 
-	return 0;
+	return error;
 }
 __initcall(omap_pm_init);


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH] ARM: OMAP: Fix warning in mach-omap1
@ 2006-11-04 15:49 Dirk Behme
  2006-11-09 23:24 ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Dirk Behme @ 2006-11-04 15:49 UTC (permalink / raw)
  To: linux-omap-open-source

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

Fix warning

arch/arm/mach-omap1/pm.c: In function 'omap_pm_init':
arch/arm/mach-omap1/pm.c:765: warning: ignoring return value
of 'subsys_create_file', declared with attribute
warn_unused_result

Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>


[-- Attachment #2: mach_omap1_warn_patch.txt --]
[-- Type: text/plain, Size: 714 bytes --]

Index: linux-osk/arch/arm/mach-omap1/pm.c
===================================================================
--- linux-osk.orig/arch/arm/mach-omap1/pm.c
+++ linux-osk/arch/arm/mach-omap1/pm.c
@@ -706,6 +706,8 @@ static struct pm_ops omap_pm_ops ={
 
 static int __init omap_pm_init(void)
 {
+	int error;
+
 	printk("Power Management for TI OMAP.\n");
 
 	/*
@@ -762,7 +764,9 @@ static int __init omap_pm_init(void)
 	omap_pm_init_proc();
 #endif
 
-	subsys_create_file(&power_subsys, &sleep_while_idle_attr);
+	error = subsys_create_file(&power_subsys, &sleep_while_idle_attr);
+	if(error)
+		printk(KERN_ERR "subsys_create_file failed: %d\n", error);
 
 	if (cpu_is_omap16xx()) {
 		/* configure LOW_PWR pin */


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-11-09 23:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-27 16:19 [PATCH] ARM: OMAP: Fix warning in mach-omap1 Dirk Behme
  -- strict thread matches above, loose matches on Subject: below --
2006-11-04 15:49 Dirk Behme
2006-11-09 23:24 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox