public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <ext-felipe.lima@nokia.com>
To: Linux OMAP Mailing List <linux-omap-open-source@linux.omap.com>
Subject: [PATCH] [USB/CORE/USB.C] Fixes autosuspend and auto_pm fields missing
Date: Tue, 31 Oct 2006 16:00:28 -0400	[thread overview]
Message-ID: <4547AB5C.4010801@nokia.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

This small patch changes omap_h3_1710_defconfig to fix the bug.

The catch is: for struct usb_device to have the fields struct 
work_struct autosuspend and unsigned autopm:1 CONFIG_PM should be set "y".


make uImage
  CHK     include/linux/version.h
make[1]: `include/asm-arm/mach-types.h' is up to date.
  CHK     include/linux/utsrelease.h
  CHK     include/linux/compile.h
  CC      drivers/usb/core/usb.o
drivers/usb/core/usb.c: In function 'usb_release_dev':
drivers/usb/core/usb.c:177: error: 'struct usb_device' has no member 
named 'autosuspend'
drivers/usb/core/usb.c: In function 'usb_autosuspend_work':
drivers/usb/core/usb.c:218: error: 'struct usb_device' has no member 
named 'auto_pm'
drivers/usb/core/usb.c:219: warning: statement with no effect
make[3]: *** [drivers/usb/core/usb.o] Error 1
make[2]: *** [drivers/usb/core] Error 2
make[1]: *** [drivers/usb] Error 2
make: *** [drivers] Error 2


-- 
Best Regards,

Felipe Balbi
ext-felipe.lima@nokia.com
OSMRC - INdT


[-- Attachment #2: patch-autosuspend-auto_pm.diff --]
[-- Type: text/x-patch, Size: 813 bytes --]

Index: linux-omap-2.6-dev/include/linux/usb.h
===================================================================
--- linux-omap-2.6-dev.orig/include/linux/usb.h	2006-10-31 14:16:01.000000000 -0400
+++ linux-omap-2.6-dev/include/linux/usb.h	2006-10-31 15:48:43.000000000 -0400
@@ -381,13 +381,13 @@ struct usb_device {
 	struct usb_device *children[USB_MAXCHILDREN];
 
 	int pm_usage_cnt;		/* usage counter for autosuspend */
-#ifdef CONFIG_PM
+/* #ifdef CONFIG_PM */
 	struct work_struct autosuspend;	/* for delayed autosuspends */
 	struct mutex pm_mutex;		/* protects PM operations */
 
 	unsigned auto_pm:1;		/* autosuspend/resume in progress */
 	unsigned do_remote_wakeup:1;	/* remote wakeup should be enabled */
-#endif
+/* #endif */
 };
 #define	to_usb_device(d) container_of(d, struct usb_device, dev)
 

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2006-10-31 20:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-31 20:00 Felipe Balbi [this message]
2006-10-31 20:28 ` [PATCH] [USB/CORE/USB.C] Fixes autosuspend and auto_pm fields missing Felipe Balbi
2006-11-01 17:09 ` Dirk Behme
2006-11-01 19:55   ` David Brownell
     [not found] <Pine.LNX.4.44L0.0611011552330.8259-100000@iolanthe.rowland.org>
2006-11-01 21:48 ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4547AB5C.4010801@nokia.com \
    --to=ext-felipe.lima@nokia.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox