public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: David Brownell <david-b@pacbell.net>
Cc: Linux OMAP Mailing List <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] [USB/CORE/USB.C] Fixes autosuspend and auto_pm fields missing
Date: Wed, 01 Nov 2006 18:09:21 +0100	[thread overview]
Message-ID: <4548D4C1.9000405@gmail.com> (raw)
In-Reply-To: <4547AB5C.4010801@nokia.com>

Hi David,

Felipe Balbi wrote:
>  CC      drivers/usb/core/usb.o
> drivers/usb/core/usb.c: In function 'usb_release_dev':
> drivers/usb/core/usb.c:177: error: 'struct usb_device' has no member 
> named 'autosuspend'
> drivers/usb/core/usb.c: In function 'usb_autosuspend_work':
> drivers/usb/core/usb.c:218: error: 'struct usb_device' has no member 
> named 'auto_pm'
> drivers/usb/core/usb.c:219: warning: statement with no effect
> make[3]: *** [drivers/usb/core/usb.o] Error 1

do we have a mismatch here between usage of CONFIG_PM in 
include/linux/usb.h and CONFIG_USB_SUSPEND in usb/core/usb.c 
if CONFIG_PM isn't set for OMAP?

Cheers

Dirk

include/linux/usb.h:

#ifdef CONFIG_PM
	struct work_struct autosuspend;	/* for delayed autosuspends */
	struct mutex pm_mutex;		/* protects PM operations */

	unsigned auto_pm:1;		/* autosuspend/resume in progress */
	unsigned do_remote_wakeup:1;	/* remote wakeup should be 
enabled */
#endif

usb/core/usb.c line ~177:

#ifdef	CONFIG_USB_SUSPEND
	cancel_delayed_work(&udev->autosuspend);
...
#endif

usb/core/usb.c line ~218:

#ifdef	CONFIG_USB_SUSPEND
...
	udev->auto_pm = 1;
...

  parent reply	other threads:[~2006-11-01 17:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-31 20:00 [PATCH] [USB/CORE/USB.C] Fixes autosuspend and auto_pm fields missing Felipe Balbi
2006-10-31 20:28 ` Felipe Balbi
2006-11-01 17:09 ` Dirk Behme [this message]
2006-11-01 19:55   ` David Brownell
     [not found] <Pine.LNX.4.44L0.0611011552330.8259-100000@iolanthe.rowland.org>
2006-11-01 21:48 ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4548D4C1.9000405@gmail.com \
    --to=dirk.behme@googlemail.com \
    --cc=david-b@pacbell.net \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox