Re: [PATCH] To add OMAP 2430 Support

[Dirk Behme <dirk.behme@googlemail.com>]

Syed Mohammed, Khasim wrote:
> ethernet_fix_2430.patch
> -----------------------
> This patch updates the GPIO interrupt line behavior for SMC91x
> interrupts on 2430 SDP.
 >
 > --- linux-omap/drivers/net/smc91x.h	2006-11-02 
00:16:21.000000000 -0600
 > +++ dev-linux-omap-2.6.git/drivers/net/smc91x.h 
2006-11-02 15:38:13.000000000 -0600
 > @@ -192,14 +192,16 @@ SMC_outw(u16 val, void __iomem 
*ioaddr,
 >  #include <asm/mach-types.h>
 >  #include <asm/arch/cpu.h>
 >
 > +#ifdef CONFIG_ARCH_OMAP2430
 > +#define SMC_IRQ_FLAGS		SA_TRIGGER_LOW
 > +#else
 > #define	SMC_IRQ_FLAGS (( \
 > 		   machine_is_omap_h2() \
 > 		|| machine_is_omap_h3() \
 > 		|| machine_is_omap_h4() \
 >		|| (machine_is_omap_innovator() && !cpu_is_omap1510()) \
 > 	) ? IRQF_TRIGGER_FALLING : IRQF_TRIGGER_RISING)
 > -
 > -
 > +#endif
 > #elif	defined(CONFIG_SH_SH4202_MICRODEV)

Regarding SA_TRIGGER_LOW, include/linux/interrupt.h tells us

/*
  * Migration helpers. Scheduled for removal in 1/2007
  * Do not use for new code !
  */
...
#define SA_TRIGGER_LOW		IRQF_TRIGGER_LOW

Any chance (even if I don't see it at the moment ;) ) to 
integrate IRQF_TRIGGER_LOW instead into the existing 
SMC_IRQ_FLAGS using machine_is_omap_2430sdp and avoiding the 
additional #ifdef?

Cheers

Dirk