[PATCH] ARM: OMAP: Fix for mailbox-omap1

[PATCH] ARM: OMAP: Fix for mailbox-omap1

[Toshihiro.Kobayashi]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

Fix for omap1 mailbox driver.
This will enable DSP Gateway again.

I'll work more on mudularization of dsp and mailbox.

BR,
Toshihiro Kobayashi

[-- Attachment #2: patch-mailbox-omap1-fix --]
[-- Type: application/octet-stream, Size: 1479 bytes --]

diff -urN linux-2.6.18-omap1/arch/arm/mach-omap1/mailbox.c linux-2.6.18-omap1-new/arch/arm/mach-omap1/mailbox.c
--- linux-2.6.18-omap1/arch/arm/mach-omap1/mailbox.c	2006-11-08 15:28:02 +09:00
+++ linux-2.6.18-omap1-new/arch/arm/mach-omap1/mailbox.c	2006-11-08 14:34:50 +09:00
@@ -67,7 +67,7 @@
 omap1_mbox_fifo_write(struct omap_mbox *mbox, mbox_msg_t msg)
 {
 	struct omap_mbox1_fifo *fifo =
-		&((struct omap_mbox1_priv *)mbox->priv)->rx_fifo;
+		&((struct omap_mbox1_priv *)mbox->priv)->tx_fifo;
 
 	mbox_write_reg(msg & 0xffff, fifo->data);
 	mbox_write_reg(msg >> 16, fifo->cmd);
@@ -110,6 +110,7 @@
 }
 
 struct omap_mbox_ops omap1_mbox_ops = {
+	.type = OMAP_MBOX_TYPE1,
 	.fifo_read = omap1_mbox_fifo_read,
 	.fifo_write = omap1_mbox_fifo_write,
 	.fifo_empty = omap1_mbox_fifo_empty,
diff -urN linux-2.6.18-omap1/arch/arm/plat-omap/mailbox.c linux-2.6.18-omap1-new/arch/arm/plat-omap/mailbox.c
--- linux-2.6.18-omap1/arch/arm/plat-omap/mailbox.c	2006-11-08 15:28:02 +09:00
+++ linux-2.6.18-omap1-new/arch/arm/plat-omap/mailbox.c	2006-11-08 15:17:38 +09:00
@@ -114,10 +114,13 @@
 	struct omap_mbox *mbox = (struct omap_mbox *)p;
 	struct omap_mbq *mbq = mbox->mbq;
 	mbox_msg_t msg;
+	int was_full;
 
 	while (!mbq_empty(mbq)) {
+		was_full = mbq_full(mbq);
 		msg = mbq_get(mbq);
-		enable_mbox_irq(mbox, IRQ_RX);
+		if (was_full)	/* now we have a room in the mbq. */
+			enable_mbox_irq(mbox, IRQ_RX);
 
 		if (unlikely(mbox_seq_test(mbox, msg))) {
 			printk(KERN_ERR

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

regarding bootloaer

[rajesh B]

Hi,
Am using rrload bootloader for porting linux in OMAP1510, am structing with some problem in loading in this booloader so any any help me with some other bootloader suppoerting for OMAP1510...


bye


rajesh.B
 
---------------------------------
Sponsored Link

Try Netflix today! With plans starting at only $5.99 a month what are you waiting for?

Re: regarding bootloaer

[Romain Goyet]

Allrifght Rajesh, you should first tell us to which kind of plateform
you're porting Linux to. Actually, "porting linux to OMAP1510" makes
virtually no sense, given that the port is already done and totally
functionnal. Porting Linux to a device using an OMAP processor would,
but you should tell us more about it if you expect an interesting
answer.

Regards,
Romain

2006/11/8, rajesh B <trytorajesh@yahoo.com>:
> Hi,
> Am using rrload bootloader for porting linux in OMAP1510, am structing with some problem in loading in this booloader so any any help me with some other bootloader suppoerting for OMAP1510...
>
>
> bye
>
>
> rajesh.B
>
> ---------------------------------
> Sponsored Link
>
> Try Netflix today! With plans starting at only $5.99 a month what are you waiting for?
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source
>

Re: regarding bootloaer

[Dirk Behme]

Romain Goyet wrote:
> Allrifght Rajesh, you should first tell us to which kind of plateform
> you're porting Linux to. Actually, "porting linux to OMAP1510" makes
> virtually no sense, given that the port is already done and totally
> functionnal.

For that matter, seems that 
drivers/input/keyboard/innovator_ps2.c used on Innovator 
1510 is broken:

   CC [M]  drivers/input/keyboard/innovator_ps2.o
drivers/input/keyboard/innovator_ps2.c: In function 
'innovator_kbd_init':
drivers/input/keyboard/innovator_ps2.c:1225: warning: 
implicit declaration of function 'init_input_dev'

WARNING: "init_input_dev" 
[drivers/input/keyboard/innovator_ps2.ko] undefined!

Cheers

Dirk

> 2006/11/8, rajesh B <trytorajesh@yahoo.com>:
> 
>> Hi,
>> Am using rrload bootloader for porting linux in OMAP1510, am structing 
>> with some problem in loading in this booloader so any any help me with 
>> some other bootloader suppoerting for OMAP1510...
>>
>>
>> bye
>>
>>
>> rajesh.B
>>
>> ---------------------------------
>> Sponsored Link
>>
>> Try Netflix today! With plans starting at only $5.99 a month what are 
>> you waiting for?
>> _______________________________________________
>> Linux-omap-open-source mailing list
>> Linux-omap-open-source@linux.omap.com
>> http://linux.omap.com/mailman/listinfo/linux-omap-open-source
>>
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source
> 

[PATCH] ARM: OMAP: Fix for mailbox-omap1 (repost)

[Toshihiro.Kobayashi]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Reposting with S-O-B.

Signed-off-by: Toshihiro Kobayashi <toshihiro.kobayashi@nokia.com>

>-----Original Message-----
>From: linux-omap-open-source-bounces@linux.omap.com 
>[mailto:linux-omap-open-source-bounces@linux.omap.com] 
>Sent: Wednesday, November 08, 2006 3:50 PM
>To: linux-omap-open-source@linux.omap.com; Doyu Hiroshi 
>(Nokia-M/Helsinki)
>Subject: [PATCH] ARM: OMAP: Fix for mailbox-omap1
>
>Fix for omap1 mailbox driver.
>This will enable DSP Gateway again.
>
>I'll work more on mudularization of dsp and mailbox.
>
>BR,
>Toshihiro Kobayashi
>

[-- Attachment #2: patch-mailbox-omap1-fix --]
[-- Type: application/octet-stream, Size: 1479 bytes --]

diff -urN linux-2.6.18-omap1/arch/arm/mach-omap1/mailbox.c linux-2.6.18-omap1-new/arch/arm/mach-omap1/mailbox.c
--- linux-2.6.18-omap1/arch/arm/mach-omap1/mailbox.c	2006-11-08 15:28:02 +09:00
+++ linux-2.6.18-omap1-new/arch/arm/mach-omap1/mailbox.c	2006-11-08 14:34:50 +09:00
@@ -67,7 +67,7 @@
 omap1_mbox_fifo_write(struct omap_mbox *mbox, mbox_msg_t msg)
 {
 	struct omap_mbox1_fifo *fifo =
-		&((struct omap_mbox1_priv *)mbox->priv)->rx_fifo;
+		&((struct omap_mbox1_priv *)mbox->priv)->tx_fifo;
 
 	mbox_write_reg(msg & 0xffff, fifo->data);
 	mbox_write_reg(msg >> 16, fifo->cmd);
@@ -110,6 +110,7 @@
 }
 
 struct omap_mbox_ops omap1_mbox_ops = {
+	.type = OMAP_MBOX_TYPE1,
 	.fifo_read = omap1_mbox_fifo_read,
 	.fifo_write = omap1_mbox_fifo_write,
 	.fifo_empty = omap1_mbox_fifo_empty,
diff -urN linux-2.6.18-omap1/arch/arm/plat-omap/mailbox.c linux-2.6.18-omap1-new/arch/arm/plat-omap/mailbox.c
--- linux-2.6.18-omap1/arch/arm/plat-omap/mailbox.c	2006-11-08 15:28:02 +09:00
+++ linux-2.6.18-omap1-new/arch/arm/plat-omap/mailbox.c	2006-11-08 15:17:38 +09:00
@@ -114,10 +114,13 @@
 	struct omap_mbox *mbox = (struct omap_mbox *)p;
 	struct omap_mbq *mbq = mbox->mbq;
 	mbox_msg_t msg;
+	int was_full;
 
 	while (!mbq_empty(mbq)) {
+		was_full = mbq_full(mbq);
 		msg = mbq_get(mbq);
-		enable_mbox_irq(mbox, IRQ_RX);
+		if (was_full)	/* now we have a room in the mbq. */
+			enable_mbox_irq(mbox, IRQ_RX);
 
 		if (unlikely(mbox_seq_test(mbox, msg))) {
 			printk(KERN_ERR

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ARM: OMAP: Fix for mailbox-omap1 (repost)

[Tony Lindgren]

* Toshihiro.Kobayashi@nokia.com <Toshihiro.Kobayashi@nokia.com> [061110 06:47]:
> Reposting with S-O-B.
> 
> Signed-off-by: Toshihiro Kobayashi <toshihiro.kobayashi@nokia.com>
> 
> >-----Original Message-----
> >From: linux-omap-open-source-bounces@linux.omap.com 
> >[mailto:linux-omap-open-source-bounces@linux.omap.com] 
> >Sent: Wednesday, November 08, 2006 3:50 PM
> >To: linux-omap-open-source@linux.omap.com; Doyu Hiroshi 
> >(Nokia-M/Helsinki)
> >Subject: [PATCH] ARM: OMAP: Fix for mailbox-omap1
> >
> >Fix for omap1 mailbox driver.
> >This will enable DSP Gateway again.
> >
> >I'll work more on mudularization of dsp and mailbox.

Thanks, pushing.

Tony