[PATCH] ARM: OMAP: Fix Apollon and OSK ethernet IRQ flags

[PATCH] ARM: OMAP: Fix Apollon and OSK ethernet IRQ flags

[Dirk Behme]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]


Fix IRQ flags for Apollon and OSK (OMAP5912) board. Apollon 
fix from
Kyungmin Park (kyungmin.park_at_samsung.com):

Apollon (omap2420) use IRQF_TRIGGER_RISING which means
IRQF_TRIGGER_HIGH.

Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>


[-- Attachment #2: smc_irq_flags_patch.txt --]
[-- Type: text/plain, Size: 824 bytes --]

Index: linux-osk/drivers/net/smc91x.h
===================================================================
--- linux-osk.orig/drivers/net/smc91x.h
+++ linux-osk/drivers/net/smc91x.h
@@ -193,10 +193,12 @@ SMC_outw(u16 val, void __iomem *ioaddr, 
 #include <asm/arch/cpu.h>
 
 #ifdef CONFIG_ARCH_OMAP1
-#define	SMC_IRQ_FLAGS	(machine_is_omap_innovator() ? IRQF_TRIGGER_RISING : \
-				IRQF_TRIGGER_FALLING)
+#define	SMC_IRQ_FLAGS	((machine_is_omap_innovator() ||  \
+                          machine_is_omap_osk())          \
+                          ? IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING)
 #else
-#define SMC_IRQ_FLAGS		IRQF_TRIGGER_LOW
+#define SMC_IRQ_FLAGS	 (machine_is_omap_apollon()       \
+                          ? IRQF_TRIGGER_HIGH : IRQF_TRIGGER_LOW)
 #endif
 
 #elif	defined(CONFIG_SH_SH4202_MICRODEV)


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ARM: OMAP: Fix Apollon and OSK ethernet IRQ flags

[Tony Lindgren]

* Dirk Behme <dirk.behme@googlemail.com> [061116 18:46]:
> 
> Fix IRQ flags for Apollon and OSK (OMAP5912) board. Apollon 
> fix from
> Kyungmin Park (kyungmin.park_at_samsung.com):
> 
> Apollon (omap2420) use IRQF_TRIGGER_RISING which means
> IRQF_TRIGGER_HIGH.
> 
> Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
> 

> Index: linux-osk/drivers/net/smc91x.h
> ===================================================================
> --- linux-osk.orig/drivers/net/smc91x.h
> +++ linux-osk/drivers/net/smc91x.h
> @@ -193,10 +193,12 @@ SMC_outw(u16 val, void __iomem *ioaddr, 
>  #include <asm/arch/cpu.h>
>  
>  #ifdef CONFIG_ARCH_OMAP1
> -#define	SMC_IRQ_FLAGS	(machine_is_omap_innovator() ? IRQF_TRIGGER_RISING : \
> -				IRQF_TRIGGER_FALLING)
> +#define	SMC_IRQ_FLAGS	((machine_is_omap_innovator() ||  \
> +                          machine_is_omap_osk())          \
> +                          ? IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING)
>  #else
> -#define SMC_IRQ_FLAGS		IRQF_TRIGGER_LOW
> +#define SMC_IRQ_FLAGS	 (machine_is_omap_apollon()       \
> +                          ? IRQF_TRIGGER_HIGH : IRQF_TRIGGER_LOW)
>  #endif
>  
>  #elif	defined(CONFIG_SH_SH4202_MICRODEV)

Heh, thanks pushing today. Did I manage to break any other boards? :)

Tony

Re: [PATCH] ARM: OMAP: Fix Apollon and OSK ethernet IRQ flags

[Dirk Behme]

Tony Lindgren wrote:
> * Dirk Behme <dirk.behme@googlemail.com> [061116 18:46]:
> 
>>Fix IRQ flags for Apollon and OSK (OMAP5912) board.
...
> Heh, thanks pushing today. Did I manage to break any other boards? :)

Thanks for pushing! Looking at defconfigs we have 
CONFIG_SMC91X=y for innovator_1610, innovator_1510, h2, h3, 
h4, osk, 2430sdp, apollon and perseus2. Except perseus2 all 
boards should be covered now.

Hint: perseus2 is worth a check ;)

Dirk