From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH] To enable I2C-2 for 2430 SDP Date: Tue, 28 Nov 2006 01:06:44 +0530 Message-ID: <456B3E4C.2060300@gmail.com> References: <77C7F7CB1230A74A9D19C0C111E6EDBE01F29AD2@DLEE09.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <77C7F7CB1230A74A9D19C0C111E6EDBE01F29AD2@DLEE09.ent.ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: "Syed Mohammed, Khasim" , linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org Syed Mohammed, Khasim stated on 11/21/2006 11:31 AM: > Hi, > > The attached patch enables I2C-2 support for 2430 SDP. On 2430SDP > Triton-2 is connected through I2C bus-2. > > Please do let me know if you find any issues with the same. - - omap_cfg_reg(J15_24XX_I2C2_SCL); - omap_cfg_reg(H19_24XX_I2C2_SDA); + + if (!cpu_is_omap2430()){ + omap_cfg_reg(J15_24XX_I2C2_SCL); + omap_cfg_reg(H19_24XX_I2C2_SDA); + } IMHO, Bad idea... do we want to handle this carefully? is this mux correct for all omap2 devices? it would rather be board specific than CPU specific.. remember that the line is out on multiple pins.. this might be a bad idea for using the silicon for other boards with a different pin out...how about muxing it only for h4?? that sounds more proper here... we assume at this point that all muxing was done in uboot for 2430?? or should we not be doing it explicitly here?? Regards, Nishanth menon