From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Ossman Subject: Re: [patch 3/5] [RFC] Add MMC Password Protection (lock/unlock) support V7: mmc_lock_unlock.diff Date: Mon, 04 Dec 2006 21:23:17 +0100 Message-ID: <457483B5.8060205@drzeus.cx> References: <4564640B.1070004@indt.org.br> <45680308.4040809@drzeus.cx> <45746CD3.1000604@indt.org.br> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45746CD3.1000604@indt.org.br> Sender: linux-kernel-owner@vger.kernel.org To: Anderson Briglia Cc: "Linux-omap-open-source@linux.omap.com" , Russell King , Tony Lindgren , "Aguiar Carlos (EXT-INdT/Manaus)" , ext David Brownell , "Lizardo Anderson (EXT-INdT/Manaus)" , linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org Anderson Briglia wrote: > > Actually they represent the bits regarding the modes and it is used > when we > have to send the LOCK/UNLOCK mode on the command data block, according > to the MMC Spec. > If you take a look at mmc_lock_unlock function, we use those modes to > set the right bit > when composing the command data block. > This definition makes the code more legible and simple. In that case you need to change the code to make sure it is clear that it is bits and not values. Also, your definition for MMC_LOCK_MODE_UNLOCK is wrong. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org