public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP2: Fix warning in pm.c
@ 2007-01-20  7:04 Dirk Behme
  2007-01-26 21:32 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Dirk Behme @ 2007-01-20  7:04 UTC (permalink / raw)
  To: linux-omap-open-source

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]


ARM: OMAP2: Fix warning in pm.c:

arch/arm/mach-omap2/pm.c: In function 'omap2_pm_init':
arch/arm/mach-omap2/pm.c:854: warning: ignoring return value
of 'subsys_create_file', declared with attribute
warn_unused_result

Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>


[-- Attachment #2: omap2_pm_warning_fix --]
[-- Type: text/plain, Size: 512 bytes --]

Index: linux-osk/arch/arm/mach-omap2/pm.c
===================================================================
--- linux-osk.orig/arch/arm/mach-omap2/pm.c
+++ linux-osk/arch/arm/mach-omap2/pm.c
@@ -851,7 +851,9 @@ int __init omap2_pm_init(void)
 	pm_set_ops(&omap_pm_ops);
 	pm_idle = omap2_pm_idle;
 
-	subsys_create_file(&power_subsys, &sleep_while_idle_attr);
+	l = subsys_create_file(&power_subsys, &sleep_while_idle_attr);
+	if (l)
+		printk(KERN_ERR "subsys_create_file failed: %d\n", l);
 
 	return 0;
 }


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: OMAP2: Fix warning in pm.c
  2007-01-20  7:04 [PATCH] ARM: OMAP2: Fix warning in pm.c Dirk Behme
@ 2007-01-26 21:32 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-01-26 21:32 UTC (permalink / raw)
  To: Dirk Behme; +Cc: linux-omap-open-source

* Dirk Behme <dirk.behme@googlemail.com> [070119 23:06]:
> 
> ARM: OMAP2: Fix warning in pm.c:
> 
> arch/arm/mach-omap2/pm.c: In function 'omap2_pm_init':
> arch/arm/mach-omap2/pm.c:854: warning: ignoring return value
> of 'subsys_create_file', declared with attribute
> warn_unused_result
> 
> Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
> 

> Index: linux-osk/arch/arm/mach-omap2/pm.c
> ===================================================================
> --- linux-osk.orig/arch/arm/mach-omap2/pm.c
> +++ linux-osk/arch/arm/mach-omap2/pm.c
> @@ -851,7 +851,9 @@ int __init omap2_pm_init(void)
>  	pm_set_ops(&omap_pm_ops);
>  	pm_idle = omap2_pm_idle;
>  
> -	subsys_create_file(&power_subsys, &sleep_while_idle_attr);
> +	l = subsys_create_file(&power_subsys, &sleep_while_idle_attr);
> +	if (l)
> +		printk(KERN_ERR "subsys_create_file failed: %d\n", l);
>  
>  	return 0;
>  }
> 

Pushing today.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-01-26 21:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-20  7:04 [PATCH] ARM: OMAP2: Fix warning in pm.c Dirk Behme
2007-01-26 21:32 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox