Re: [PATCH] ARM: OMAP2: Camera: Adapt to 2.6.20.

[Sakari Ailus <sakari.ailus@nokia.com>]

ext Trilok Soni wrote:
> I think you have not looked at patches posted by me about OMAP2420
> camera. Part of the changes are taken from N800 kernel tree and TI's
> tree. Those sensor interface changes are also changed to adapt TI
> Micron sensor. I believe you should have worked on those changes and
> modified sensor interface for N800. Why re-work?

I was actually thinking of that sensor interface change due to Micron 
sensor (in your patches) a bit. Anyway, as I said, this is a work in 
progress, and I've been just trying to keep the driver somehow functional.

I don't like the original sensor interface very much. It passes void 
pointers with no name to interface functions, these pointers obviously 
point to some sensor private data. Then the init function returns the 
pointer to the sensor. Hmm.

I'd like that the sensor didn't know about the camera. This is 
accomplished by adding a generic camera interface with register, reset 
(so far specific to N800) and unregister. The sensor could then register 
itself to the camera, whose pointer it gets from its configuration 
(machine specific).

module field has been added so that the camera can try_module_get() the 
sensor when the device is opened. Beyond that it's just what I see fit. 
:) This is all naturally open for changes.

> http://linux.omap.com/pipermail/linux-omap-open-source/2007-February/009062.html 
> 
> http://linux.omap.com/pipermail/linux-omap-open-source/2007-February/009063.html 
> 
> http://linux.omap.com/pipermail/linux-omap-open-source/2007-February/009069.html 
> 
> http://linux.omap.com/pipermail/linux-omap-open-source/2007-February/009064.html 
> 
> http://linux.omap.com/pipermail/linux-omap-open-source/2007-February/009065.html 
> 
> 
> Please help me to review above patches instead, then we will have less
> re-work and come to conclusion, whose patches should be integrated
> instead. BTW, I have N800 so I can test this sensor now.

I'll have a look.

-- 
Sakari Ailus
sakari.ailus@nokia.com