From: Dirk Behme <dirk.behme@googlemail.com>
To: linux-omap-open-source@linux.omap.com,
Nishanth Menon <menon.nishanth@gmail.com>,
Imre Deak <imre.deak@solidboot.com>,
Brian Swetland <swetland@google.com>,
jekyll@mail.jekyll.idv.tw, lastjp_fr@yahoo.fr,
swetland@android.com
Subject: Re: [PATCH] add ssi/Kconfig to arch/arm/Kconfig
Date: Mon, 05 Mar 2007 20:56:53 +0100 [thread overview]
Message-ID: <45EC7605.8060808@googlemail.com> (raw)
In-Reply-To: <20070305100136.GC17801@atomide.com>
Tony Lindgren wrote:
> * Arnaud Patard <arnaud.patard@rtp-net.org> [070304 12:25]:
>
>>Dirk Behme <dirk.behme@googlemail.com> writes:
>>
>>
>>>Arnaud Patard (Rtp) wrote:
>>>
>>>>If one wants to use ssi/Kconfig on arm, it should be added to
>>>>arch/arm/Kconfig.
>>>
>>>Yes, I found this as well by getting
>>>
>>>sound/arm/Kconfig:55:warning: 'select' used by config symbol
>>>'SND_OMAP_TSC2101' refer to undefined symbol 'OMAP_TSC2101'
>>>sound/arm/Kconfig:56:warning: 'select' used by config symbol
>>>'SND_OMAP_TSC2101' refer to undefined symbol 'OMAP_UWIRE'
>>>
>>>Kconfig warnings.
>>
>>same here :)
>>
>>
>>>While touching this, what do you think about doing some more
>>>clean up:
>>>
>>>- omap_uwire.c is now in drivers/spi [], remove (old?) one from
>>>drivers/ssi
>>
>>I had the same patch but you send it before me :)
>>
>>
>>>- Replace OMAP_UWIRE in Kconfig by SPI_OMAP_UWIRE pointing
>>>to drivers/spi
>>>
>>>?
>>>
>>
>>Even if I'm not a omap dev, I'll be happy to see the ssi stuff go to
>>/dev/null. Unfortunately, grep is telling us that there are still users
>>of the old omap_uwire. Moreover, it seems that it's possible to build a
>>kernel without the OMAP_UWIRE and with the drivers using it. The drivers
>>using the old ssi stuff should either depends on it or select it...
>>(see drivers/video/omap/lcd_{p,h}2.c).
>>Until this is solved, we won't be able to remove it :(
>
>
> I agree, let's get rid of the old drivers/ssi, anything using it should
> be updated to use drivers/spi.
Yes.
All: Following files need update. Let's try the names in
file headers:
* drivers/video/omap/lcd_h2.c
-> update to use drivers/spi/omap-uwire
-> Imre?
* drivers/video/omap/lcd_p2.c
-> update to use drivers/spi/omap-uwire
-> jekyll & B Jp & Brian Swetland?
* drivers/ssi/omap-tsc2101.{c,h}
-> update to use drivers/spi/omap-uwire and move it to
drivers/spi
-> Nishanth?
Anything else?
Until this is done, only thing we can do to make Kconfig
happy is
http://linux.omap.com/pipermail/linux-omap-open-source/2007-March/009220.html
Dirk
next prev parent reply other threads:[~2007-03-05 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-04 12:30 [PATCH] add ssi/Kconfig to arch/arm/Kconfig Arnaud Patard
2007-03-04 17:11 ` Dirk Behme
2007-03-04 20:20 ` Arnaud Patard
2007-03-05 10:01 ` Tony Lindgren
2007-03-05 19:56 ` Dirk Behme [this message]
2007-03-05 20:32 ` Brian Swetland
2007-03-08 10:36 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EC7605.8060808@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=imre.deak@solidboot.com \
--cc=jekyll@mail.jekyll.idv.tw \
--cc=lastjp_fr@yahoo.fr \
--cc=linux-omap-open-source@linux.omap.com \
--cc=menon.nishanth@gmail.com \
--cc=swetland@android.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox