Re: [PATCH] sound: soc: ti: omap3pandora: fix stale ARM machine ID check to use DT

[Jarkko Nikula <jarkko.nikula@bitmer.com>]

Hi

On 09/05/2026 5:08 am, Ethan Nelson-Moore wrote:
> The omap3pandora driver contains a check for the ARM machine ID via the
> machine_is_omap3_pandora() macro. This check is incorrect because the
> machine concerned now supports only FDT booting, which does not use
> machine IDs, and therefore it will always fail. The legacy board file
> for this machine was removed in commit 7fcf7e061edd ("ARM: OMAP2+:
> Remove legacy booting support for Pandora"). To resolve this issue, use
> of_machine_is_compatible() instead.
>
> Fixes: b715da74deaf ("ARM: dts: omap3-pandora: add OMAP3530 600 MHz version")
> Fixes: 9ccd0106c9db ("ARM: dts: omap3-pandora: add DM3730 1 GHz version")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
>  sound/soc/ti/omap3pandora.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

I guess this is the same than rx51 case that machine_is_omap3_pandora()
still returns true. Dunno is there an updated bootloader for it that
doesn't pass anymore the ID but I think only that case would warrant the
Fixes tags?