Re: [PATCH] SD working on OMAP platforms

Pierre Ossman
2007-04-03T04:37:28Z

Carlos Aguiar wrote:
> On CMD3, response type is R6 to SD cards and R1 to MMC cards.
> This fix ignores the buggy SD handling on CMD3.
>
>

This is misleading. The problem is the OMAP controller trying to be
smart with the end result of it doing something completely wrong. The
controller parses data when it has no idea what we want parsed.

> + if (status == 0x4000) {
> + dev_dbg(mmc_dev(host->mmc),
> + "buggy SD handling, ignoring it\n");
> + status = 0x0001;
> + }
> +
>

Some defines for those constants would be nice. And the debug message
should be more general

Rgds

--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org