Hi Trilok and Tony, Thanks a zillion for helping out with the patch Trilok Soni stated on 4/5/2007 8:42 AM: > Nop. You have only made change in wdt_probe, but missed wdt_remove for > setting drvdata to NULL. Please do the same there. Done. Thanks for catching it - boy am I sleepy in the morning... Trilok Soni stated on 4/5/2007 8:00 AM: > But the compiler is intelligent. So, I don't think this unnecessary > castings is needed at all. Yup.. accepted this too. Tony Lindgren stated on 4/5/2007 8:30 AM: > The problem with this is that we will always get nailed on that > trying to send the patches upstream, see current omap update on LKML > right now for example. So we should generate patches that do not > leave any reason for anybody to complain. > > My hopes of eternal notoriety is dashed to pieces :(... I saw the discussion on LKML... ouch.... next time i put an '||' i will be careful :) Hope the attached patch takes care of all concerns and i can listen to my 2430 bark again :) ..my expertise with generating git patches and signing off seems pretty basic.. so apologies in advance on it.. Regards, Nishanth Menon