Re:Re:Re: [PATCH v2] bus/ti-sys: Fix refcount leak bugs

Liang He
2022-06-28T06:24:28Z

At 2022-06-28 14:09:37, "Liang He" <windhl@126.com> wrote:
>
>
>
>At 2022-06-28 14:02:07, "Tony Lindgren" <tony@atomide.com> wrote:
>>* Liang He <windhl@126.com> [220620 17:51]:
>>> --- a/drivers/bus/ti-sysc.c
>>> +++ b/drivers/bus/ti-sysc.c
>>> @@ -751,6 +751,7 @@ static void sysc_init_stdout_path(struct sysc *ddata)
>>> goto err;
>>>
>>> uart = of_get_property(np, "stdout-path", NULL);
>>> + of_node_put(np);
>>> if (!uart)
>>> goto err;
>>>
>>
>>Looks like you missed another of_node_put() after of_find_node_by_path()
>>in sysc_init_stdout_path(). Please add it and repost.
>>
>>Thanks,
>>
>>Tony
>

>Thanks, I will resend a new patch soon.

Sorry, Tony.

I have re-checked the sysc_init_stdout_path(), I think the second of_node_put
is not needed as the second 'np' will be escaped out into global 'stdout_path'.

If my understanding is wrong, please correct me.

Thanks.
Liang