From: Kevin Hilman <khilman@mvista.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [patch linux-omap-git] fix SPI_CPHA related errors
Date: Wed, 23 May 2007 09:50:57 -0700 [thread overview]
Message-ID: <465470F1.2020109@mvista.com> (raw)
In-Reply-To: <200705222232.27584.david-b@pacbell.net>
David Brownell wrote:
> The OMAP SPI controller drivers handle SPI_CPHA incorrectly.
> It should mean:
>
> CPHA=0 ... sample at leading edge of clock
> CPHA=1 ... sample at trailing edge of clock
>
> This fixes them, and the protocol drivers which depended on the wrong
> meaning. Separate ads7846 and omap_uwire patches are going upstream,
> already since those drivers were already pushed there. The tsc2102
> code already had this right ... strange.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Verified that tsc2046 driver still works.
Acked-by: Kevin Hilman <khilman@mvista.com>
next prev parent reply other threads:[~2007-05-23 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 5:32 [patch linux-omap-git] fix SPI_CPHA related errors David Brownell
2007-05-23 16:50 ` Kevin Hilman [this message]
2007-05-25 0:36 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465470F1.2020109@mvista.com \
--to=khilman@mvista.com \
--cc=david-b@pacbell.net \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox