From: Nishanth Menon <menon.nishanth@gmail.com>
To: "Syed Mohammed, Khasim" <x0khasim@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] To Cleanup TWL-Core driver
Date: Thu, 26 Jul 2007 06:16:03 -0500 [thread overview]
Message-ID: <46A88273.6090305@gmail.com> (raw)
In-Reply-To: <9C23CDD79DA20A479D4615857B2E2C47016A3486@dlee13.ent.ti.com>
Syed Mohammed, Khasim stated on 7/25/2007 7:19 PM:
> diff -purN linux-omap/include/asm-arm/arch-omap/twl4030.h lin_for_mmc/include/asm-arm/arch-omap/twl4030.h
>
> +/*
> + * Exported TWL4030 GPIO APIs
> + */
> +int twl4030_get_gpio_datain(int gpio);
> +int twl4030_request_gpio(int gpio);
> +int twl4030_set_gpio_edge_ctrl(int gpio, int edge);
> +int twl4030_set_gpio_debounce(int gpio, int enable);
> +int twl4030_free_gpio(int gpio);
> +
> #endif /* End of __TWL4030_H */
> _______________________________________________
>
I think twl4030.h is a shared header & twlgpio driver is independent of
twl core driver. if i disable this, there wont be even a warning for the
file using this apis. why dont we cover them with the CONFIG macro for
twl gpio? - Am not sure if that is acceptable as per coding standards OR
if we need to create another shared header??...
Regards,
Nishanth Menon
next prev parent reply other threads:[~2007-07-26 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 0:19 [PATCH] To Cleanup TWL-Core driver Syed Mohammed, Khasim
2007-07-26 11:16 ` Nishanth Menon [this message]
2007-08-10 9:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A88273.6090305@gmail.com \
--to=menon.nishanth@gmail.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=x0khasim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox