From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH] To Cleanup TWL-Core driver Date: Thu, 26 Jul 2007 06:16:03 -0500 Message-ID: <46A88273.6090305@gmail.com> References: <9C23CDD79DA20A479D4615857B2E2C47016A3486@dlee13.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9C23CDD79DA20A479D4615857B2E2C47016A3486@dlee13.ent.ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: "Syed Mohammed, Khasim" Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org Syed Mohammed, Khasim stated on 7/25/2007 7:19 PM: > diff -purN linux-omap/include/asm-arm/arch-omap/twl4030.h lin_for_mmc/include/asm-arm/arch-omap/twl4030.h > > +/* > + * Exported TWL4030 GPIO APIs > + */ > +int twl4030_get_gpio_datain(int gpio); > +int twl4030_request_gpio(int gpio); > +int twl4030_set_gpio_edge_ctrl(int gpio, int edge); > +int twl4030_set_gpio_debounce(int gpio, int enable); > +int twl4030_free_gpio(int gpio); > + > #endif /* End of __TWL4030_H */ > _______________________________________________ > I think twl4030.h is a shared header & twlgpio driver is independent of twl core driver. if i disable this, there wont be even a warning for the file using this apis. why dont we cover them with the CONFIG macro for twl gpio? - Am not sure if that is acceptable as per coding standards OR if we need to create another shared header??... Regards, Nishanth Menon