Re: [PATCH 1/2] ARM: OMAP: MUSB: dont exit with spinlock held

[Kevin Hilman <khilman@mvista.com>]

David Brownell wrote:
>> From linux-omap-open-source-bounces@linux.omap.com  Thu Aug 30 20:07:19 2007
>> Date: Thu, 30 Aug 2007 19:54:00 -0700
>> From: Kevin Hilman <khilman@mvista.com>
>> To: linux-omap-open-source@linux.omap.com
>> Subject: [PATCH 1/2] ARM: OMAP: MUSB: dont exit with spinlock held
>>
>> Signed-off-by: Kevin Hilman <khilman@mvista.com>
>>
>> ---
>>  drivers/usb/musb/musb_core.c |    7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> Index: dev/drivers/usb/musb/musb_core.c
>> ===================================================================
>> --- dev.orig/drivers/usb/musb/musb_core.c
>> +++ dev/drivers/usb/musb/musb_core.c
>> @@ -1682,19 +1682,22 @@ musb_vbus_store(struct device *dev, stru
>>  	struct musb	*musb = dev_to_musb(dev);
>>  	unsigned long	flags;
>>  	unsigned long	val;
>> +	ssize_t retval = n;
>>  
>>  	spin_lock_irqsave(&musb->lock, flags);
>>  	if (sscanf(buf, "%lu", &val) < 1) {
> 
> What's it doing grabbing the spinlock before sscanf() anyway?
> It's not loke any protected data is handed off to sscanf()...
> This should instead be:
> 
> 	if (sscanf(...)...)
> 		return -EINVAL
> 
> 	spin_lock_irqsave(...)
> 
> General rule of thumb:  don't grab spinlocks earlier than necessary.
> 

Agreed, will re-submit.