From: Kevin Hilman <khilman@mvista.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 0/2] MUSB: tracking down locking bugs
Date: Thu, 30 Aug 2007 23:04:13 -0700 [thread overview]
Message-ID: <46D7AF5D.2020204@mvista.com> (raw)
In-Reply-To: <20070831054830.13B7B21D977@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
David Brownell wrote:
>> With the help of the lock debugging features of the -rt patch, I'm
>> trying to track down locking issues in the MUSB driver.
>
> It was last done about 18 months ago, so it's clearly Time to
> check those locks again. :)
Agreed.
In the short term, I'll have a couple more "band-aid" style patches for
you to sanity check. They fix a couple deadlocks uncovered by my
'BUG_ON' patch, but since I don't know this driver all that well, there
may be better ways to do things.
For the long term, more lock granularity should probably be used. For
example, currently the entire interrupt handler wrapped with a
spin_lock_irqsave(). When moving to the threaded interrupts of
PREEMPT_RT, this effictively negates the benefit of having threaded
handlers in the first place.
Kevin
next prev parent reply other threads:[~2007-08-31 6:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 2:53 [PATCH 0/2] MUSB: tracking down locking bugs Kevin Hilman
2007-08-31 2:54 ` [PATCH 1/2] ARM: OMAP: MUSB: dont exit with spinlock held Kevin Hilman
2007-08-31 5:47 ` David Brownell
2007-08-31 5:51 ` Kevin Hilman
2007-08-31 2:54 ` [PATCH 2/2] ARM: OMAP: MUSB: BUG on potential deadlocks Kevin Hilman
2007-08-31 6:05 ` David Brownell
2007-08-31 16:18 ` Kevin Hilman
2007-08-31 17:49 ` David Brownell
2007-08-31 18:41 ` Kevin Hilman
2007-08-31 20:10 ` David Brownell
2007-08-31 5:48 ` [PATCH 0/2] MUSB: tracking down locking bugs David Brownell
2007-08-31 6:04 ` Kevin Hilman [this message]
2007-08-31 6:38 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D7AF5D.2020204@mvista.com \
--to=khilman@mvista.com \
--cc=david-b@pacbell.net \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox