Re: [01/17 PATCH] MMC: OMAP: Introduces new structures for MMC multislot support.

[Carlos Aguiar <carlos.aguiar@indt.org.br>]

ext Tony Lindgren wrote:
> * Carlos Aguiar <carlos.aguiar@indt.org.br> [070903 07:00]:
>   
>> ext David Brownell wrote:
>>     
>>> On Friday 17 August 2007, David Brownell wrote:
>>>   
>>>       
>>>> On Friday 17 August 2007, Carlos Aguiar wrote:
>>>>     
>>>>         
>>>>> Introduces new structures for MMC multislot support.
>>>>>       
>>>>>           
>>>> Seems like #1 and #2 should be a single patch, since
>>>> after #1 it won't compile ...
>>>>     
>>>>         
>>>   
>>>       
>> Hi Dave,
>>     
>>> ... and maybe #3, and ... ?
>>>   
>>>       
>> You're right! But this 'level of granularity' of the patches was
>> requested by Tony.
>>     
>
> Huh? Naturally the patch series should compile and work after each
> step no matter what "level of granularity".
>
>   
>>> Also, this doesn't look to me primarily like "multislot"
>>> support.  It's also "stop relying on GPIOs" for various
>>> things that newer boards handle with external chips
>>> (like CD and WP switches), and "move board-specific code
>>> out of the MMC driver"...
>>>   
>>>       
>> The concept of multislot applied here is to provide a code (and needed
>> modifications) that runs OMAP platforms with a single and/or two MMC slots.
>>     
>
> Carlos, what Dave is saying above is that the patches don't do what you have
> in the patch description. You should try to do a series of independent
> easy to read patches that match the patch description.
>
> Regards,
>
> Tony
>
>   
Ok Tony,

I'll re-work on the series in order to have the code compiling and
working after each patch applied and each patch having a description
that matches what is doing.

BR,

Carlos.

-- 
Carlos Eduardo Aguiar
Nokia Institute of Technology - INdT
Open Source Mobile Research Center - OSMRC - Manaus
Core Team
Phone: +55 92 2126-1079
Mobile: +55 92 8127-1797
E-mail: carlos.aguiar@indt.org.br