From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlos Aguiar Subject: Re: [01/17 PATCH] MMC: OMAP: Introduces new structures for MMC multislot support. Date: Mon, 03 Sep 2007 13:38:34 -0400 Message-ID: <46DC469A.4010702@indt.org.br> References: <46C5F08D.7070207@indt.org.br> <200708171445.28921.david-b@pacbell.net> <200708171455.15439.david-b@pacbell.net> <46DC1262.1000002@indt.org.br> <20070903154510.GC21056@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070903154510.GC21056@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces+gplao-linux-omap-open-source=gmane.org@linux.omap.com Errors-To: linux-omap-open-source-bounces+gplao-linux-omap-open-source=gmane.org@linux.omap.com To: ext Tony Lindgren Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org ext Tony Lindgren wrote: > * Carlos Aguiar [070903 07:00]: > >> ext David Brownell wrote: >> >>> On Friday 17 August 2007, David Brownell wrote: >>> >>> >>>> On Friday 17 August 2007, Carlos Aguiar wrote: >>>> >>>> >>>>> Introduces new structures for MMC multislot support. >>>>> >>>>> >>>> Seems like #1 and #2 should be a single patch, since >>>> after #1 it won't compile ... >>>> >>>> >>> >>> >> Hi Dave, >> >>> ... and maybe #3, and ... ? >>> >>> >> You're right! But this 'level of granularity' of the patches was >> requested by Tony. >> > > Huh? Naturally the patch series should compile and work after each > step no matter what "level of granularity". > > >>> Also, this doesn't look to me primarily like "multislot" >>> support. It's also "stop relying on GPIOs" for various >>> things that newer boards handle with external chips >>> (like CD and WP switches), and "move board-specific code >>> out of the MMC driver"... >>> >>> >> The concept of multislot applied here is to provide a code (and needed >> modifications) that runs OMAP platforms with a single and/or two MMC slots. >> > > Carlos, what Dave is saying above is that the patches don't do what you have > in the patch description. You should try to do a series of independent > easy to read patches that match the patch description. > > Regards, > > Tony > > Ok Tony, I'll re-work on the series in order to have the code compiling and working after each patch applied and each patch having a description that matches what is doing. BR, Carlos. -- Carlos Eduardo Aguiar Nokia Institute of Technology - INdT Open Source Mobile Research Center - OSMRC - Manaus Core Team Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: carlos.aguiar@indt.org.br