From: Dirk Behme <dirk.behme@googlemail.com>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH 1/1] ARM: OMAP: Fix musb_core parameter passing to cppi start
Date: Mon, 08 Oct 2007 20:35:14 +0200 [thread overview]
Message-ID: <470A7862.4060802@googlemail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
cppi_controller_start() expects a struct dma_controller as parameter
and not dma_controller private_data. Current implementation crashes
with e.g.
Internal error: Oops: 805 [#1]
Modules linked in:
CPU: 0 Not tainted (2.6.23-rc4-davinci1 #2)
PC is at cppi_controller_start+0x18/0x140
LR is at musb_probe+0x1f4/0x824
Fix this. Initial proposal for fix by David Brownell. Thanks!
Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
[-- Attachment #2: musb_core_oops_fix.txt --]
[-- Type: text/plain, Size: 490 bytes --]
Index: linux-osk/drivers/usb/musb/musb_core.c
===================================================================
--- linux-osk.orig/drivers/usb/musb/musb_core.c
+++ linux-osk/drivers/usb/musb/musb_core.c
@@ -1980,7 +1980,7 @@ musb_init_controller(struct device *dev,
c = dma_controller_create(musb, musb->mregs);
musb->dma_controller = c;
if (c)
- (void) c->start(c->private_data);
+ (void) c->start(c);
}
#endif
/* ideally this would be abstracted in platform setup */
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2007-10-08 18:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 18:35 Dirk Behme [this message]
2007-10-09 22:25 ` [PATCH 1/1] ARM: OMAP: Fix musb_core parameter passing to cppi start Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470A7862.4060802@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox