* [PATCH] OMAP: Add OMAP_GPIO_SWITCH dependency for TUSB6010 on N800
@ 2007-10-16 21:58 Anderson Briglia
2007-10-22 0:06 ` Tony Lindgren
2007-11-21 15:06 ` [PATCH] OMAP: Moving TWL id for i2c in board files Chandra shekhar
0 siblings, 2 replies; 5+ messages in thread
From: Anderson Briglia @ 2007-10-16 21:58 UTC (permalink / raw)
To: Linux-omap-open-source@linux.omap.com
GPIO switch is needed for TUSB6010 code. It must be
selected when TUSB6010 is marked on N800 device.
Signed-off-by: Anderson Briglia <anderson.briglia@indt.org.br>
---
arch/arm/mach-omap2/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 51fc13a..9323bd0 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -37,6 +37,7 @@ config MACH_NOKIA_N800
select CBUS if VIDEO_TCM825X
select CBUS_RETU if VIDEO_TCM825X
select MENELAUS if VIDEO_TCM825X
+ select OMAP_GPIO_SWITCH
config MACH_OMAP2_TUSB6010
bool
--
1.5.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: Add OMAP_GPIO_SWITCH dependency for TUSB6010 on N800
2007-10-16 21:58 [PATCH] OMAP: Add OMAP_GPIO_SWITCH dependency for TUSB6010 on N800 Anderson Briglia
@ 2007-10-22 0:06 ` Tony Lindgren
2007-10-22 16:07 ` Anderson Briglia
2007-11-21 15:06 ` [PATCH] OMAP: Moving TWL id for i2c in board files Chandra shekhar
1 sibling, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2007-10-22 0:06 UTC (permalink / raw)
To: Anderson Briglia; +Cc: Linux-omap-open-source@linux.omap.com
Hi,
* Anderson Briglia <anderson.briglia@indt.org.br> [071016 15:00]:
> GPIO switch is needed for TUSB6010 code. It must be
> selected when TUSB6010 is marked on N800 device.
>
> Signed-off-by: Anderson Briglia <anderson.briglia@indt.org.br>
> ---
> arch/arm/mach-omap2/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 51fc13a..9323bd0 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -37,6 +37,7 @@ config MACH_NOKIA_N800
> select CBUS if VIDEO_TCM825X
> select CBUS_RETU if VIDEO_TCM825X
> select MENELAUS if VIDEO_TCM825X
> + select OMAP_GPIO_SWITCH
>
> config MACH_OMAP2_TUSB6010
> bool
At least the comment is wrong, can you please check? There's not
gpio_switch dependency in tusb6010 code AFAIK.
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: Add OMAP_GPIO_SWITCH dependency for TUSB6010 on N800
2007-10-22 0:06 ` Tony Lindgren
@ 2007-10-22 16:07 ` Anderson Briglia
0 siblings, 0 replies; 5+ messages in thread
From: Anderson Briglia @ 2007-10-22 16:07 UTC (permalink / raw)
To: ext Tony Lindgren; +Cc: Linux-omap-open-source@linux.omap.com
ext Tony Lindgren wrote:
> Hi,
>
> * Anderson Briglia <anderson.briglia@indt.org.br> [071016 15:00]:
>> GPIO switch is needed for TUSB6010 code. It must be
>> selected when TUSB6010 is marked on N800 device.
>>
>> Signed-off-by: Anderson Briglia <anderson.briglia@indt.org.br>
>> ---
>> arch/arm/mach-omap2/Kconfig | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>> index 51fc13a..9323bd0 100644
>> --- a/arch/arm/mach-omap2/Kconfig
>> +++ b/arch/arm/mach-omap2/Kconfig
>> @@ -37,6 +37,7 @@ config MACH_NOKIA_N800
>> select CBUS if VIDEO_TCM825X
>> select CBUS_RETU if VIDEO_TCM825X
>> select MENELAUS if VIDEO_TCM825X
>> + select OMAP_GPIO_SWITCH
>>
>> config MACH_OMAP2_TUSB6010
>> bool
>
> At least the comment is wrong, can you please check? There's not
> gpio_switch dependency in tusb6010 code AFAIK.
Yes, you're right. I'm re-sending with another comment.
>
> Tony
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] OMAP: Moving TWL id for i2c in board files
2007-10-16 21:58 [PATCH] OMAP: Add OMAP_GPIO_SWITCH dependency for TUSB6010 on N800 Anderson Briglia
2007-10-22 0:06 ` Tony Lindgren
@ 2007-11-21 15:06 ` Chandra shekhar
2007-11-23 21:20 ` Tony Lindgren
1 sibling, 1 reply; 5+ messages in thread
From: Chandra shekhar @ 2007-11-21 15:06 UTC (permalink / raw)
To: linux-omap-open-source
This patch moves the the adapter number from twl core file to board files.
Signed-off-by: chandra shekhar <x0044955@ti.com>
---
drivers/i2c/chips/twl4030_core.c | 2 --
include/asm/arch/board-2430sdp.h | 3 +++
include/asm/arch/board-3430sdp.h | 2 ++
3 files changed, 5 insertions(+), 2 deletions(-)
Index: linux-git-anand-19NOV/drivers/i2c/chips/twl4030_core.c
===================================================================
--- linux-git-anand-19NOV.orig/drivers/i2c/chips/twl4030_core.c 2007-11-18 23:30:05.000000000 -0500
+++ linux-git-anand-19NOV/drivers/i2c/chips/twl4030_core.c 2007-11-21 11:49:56.219607432 -0500
@@ -131,8 +131,6 @@
#define HFCLK_FREQ_38p4_MHZ (3 << 0)
#define HIGH_PERF_SQ (1 << 3)
-/* on I2C-1 for 2430SDP */
-#define CONFIG_I2C_TWL4030_ID 1
/**** Helper functions */
static int
Index: linux-git-anand-19NOV/include/asm/arch/board-2430sdp.h
===================================================================
--- linux-git-anand-19NOV.orig/include/asm/arch/board-2430sdp.h 2007-11-18 23:31:52.000000000 -0500
+++ linux-git-anand-19NOV/include/asm/arch/board-2430sdp.h 2007-11-21 11:49:25.828227624 -0500
@@ -34,6 +34,9 @@
#define OMAP24XX_ETHR_GPIO_IRQ 149
#define SDP2430_CS0_BASE 0x04000000
+/* on I2C-2 for 2430SDP */
+#define CONFIG_I2C_TWL4030_ID 2
+
#define TWL4030_IRQNUM INT_24XX_SYS_NIRQ
/* TWL4030 Primary Interrupt Handler (PIH) interrupts */
Index: linux-git-anand-19NOV/include/asm/arch/board-3430sdp.h
===================================================================
--- linux-git-anand-19NOV.orig/include/asm/arch/board-3430sdp.h 2007-11-18 23:31:52.000000000 -0500
+++ linux-git-anand-19NOV/include/asm/arch/board-3430sdp.h 2007-11-21 11:49:41.887786200 -0500
@@ -61,6 +61,8 @@
#define ONENAND_MAP 0x20000000 /* OneNand flash */
#ifdef CONFIG_TWL4030_CORE
+/* on I2C-1 for 3430SDP */
+#define CONFIG_I2C_TWL4030_ID 1
#define TWL4030_IRQNUM INT_34XX_SYS_NIRQ
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: Moving TWL id for i2c in board files
2007-11-21 15:06 ` [PATCH] OMAP: Moving TWL id for i2c in board files Chandra shekhar
@ 2007-11-23 21:20 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2007-11-23 21:20 UTC (permalink / raw)
To: Chandra shekhar; +Cc: linux-omap-open-source
* Chandra shekhar <x0044955@ti.com> [071121 07:07]:
> This patch moves the the adapter number from twl core file to board files.
>
> Signed-off-by: chandra shekhar <x0044955@ti.com>
> ---
> drivers/i2c/chips/twl4030_core.c | 2 --
> include/asm/arch/board-2430sdp.h | 3 +++
> include/asm/arch/board-3430sdp.h | 2 ++
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
> Index: linux-git-anand-19NOV/drivers/i2c/chips/twl4030_core.c
> ===================================================================
> --- linux-git-anand-19NOV.orig/drivers/i2c/chips/twl4030_core.c 2007-11-18 23:30:05.000000000 -0500
> +++ linux-git-anand-19NOV/drivers/i2c/chips/twl4030_core.c 2007-11-21 11:49:56.219607432 -0500
> @@ -131,8 +131,6 @@
> #define HFCLK_FREQ_38p4_MHZ (3 << 0)
> #define HIGH_PERF_SQ (1 << 3)
>
> -/* on I2C-1 for 2430SDP */
> -#define CONFIG_I2C_TWL4030_ID 1
>
> /**** Helper functions */
> static int
> Index: linux-git-anand-19NOV/include/asm/arch/board-2430sdp.h
> ===================================================================
> --- linux-git-anand-19NOV.orig/include/asm/arch/board-2430sdp.h 2007-11-18 23:31:52.000000000 -0500
> +++ linux-git-anand-19NOV/include/asm/arch/board-2430sdp.h 2007-11-21 11:49:25.828227624 -0500
> @@ -34,6 +34,9 @@
> #define OMAP24XX_ETHR_GPIO_IRQ 149
> #define SDP2430_CS0_BASE 0x04000000
>
> +/* on I2C-2 for 2430SDP */
> +#define CONFIG_I2C_TWL4030_ID 2
> +
> #define TWL4030_IRQNUM INT_24XX_SYS_NIRQ
>
> /* TWL4030 Primary Interrupt Handler (PIH) interrupts */
> Index: linux-git-anand-19NOV/include/asm/arch/board-3430sdp.h
> ===================================================================
> --- linux-git-anand-19NOV.orig/include/asm/arch/board-3430sdp.h 2007-11-18 23:31:52.000000000 -0500
> +++ linux-git-anand-19NOV/include/asm/arch/board-3430sdp.h 2007-11-21 11:49:41.887786200 -0500
> @@ -61,6 +61,8 @@
> #define ONENAND_MAP 0x20000000 /* OneNand flash */
>
> #ifdef CONFIG_TWL4030_CORE
> +/* on I2C-1 for 3430SDP */
> +#define CONFIG_I2C_TWL4030_ID 1
>
> #define TWL4030_IRQNUM INT_34XX_SYS_NIRQ
This will again break any chance of compiling in support for multiple
omap2 and omap3 boards. Could you please update this to get the ID
configuration from board-*.c files? See how tps65010 handles it
for example.
Regards,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-11-23 21:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-16 21:58 [PATCH] OMAP: Add OMAP_GPIO_SWITCH dependency for TUSB6010 on N800 Anderson Briglia
2007-10-22 0:06 ` Tony Lindgren
2007-10-22 16:07 ` Anderson Briglia
2007-11-21 15:06 ` [PATCH] OMAP: Moving TWL id for i2c in board files Chandra shekhar
2007-11-23 21:20 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox