From: Dirk Behme <dirk.behme@googlemail.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Fix usb gadget related compile errors and typo
Date: Tue, 30 Oct 2007 17:37:48 +0100 [thread overview]
Message-ID: <47275DDC.7060002@googlemail.com> (raw)
In-Reply-To: <20071029201114.0CD6B4A69D@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
David Brownell wrote:
>>- * gadget_is_dualspeed - return true iff the hardware handles high speed
>>+ * gadget_is_dualspeed - return true if the hardware handles high speed
>
> Not a typo; "iff" == "if and only if". NAK to that part.
Sorry. Sometimes its hard to be a non-native speaker ;)
> Re the other, please make those parts match what's upstream;
Creating the patch ~3 hours after Tonys "update linux-omap to mainline
tree" I assumed OMAP git was in sync with mainline.
> I think you added extra parens.
Yes. I tried to fix this compilation error:
CC drivers/usb/gadget/omap_udc.o
drivers/usb/gadget/omap_udc.c: In function 'pullup_enable':
drivers/usb/gadget/omap_udc.c:1244: error: incompatible type for
argument 1 of 'gadget_is_otg'
drivers/usb/gadget/omap_udc.c: In function 'pullup_disable':
drivers/usb/gadget/omap_udc.c:1251: error: incompatible type for
argument 1 of 'gadget_is_otg'
drivers/usb/gadget/omap_udc.c: In function 'update_otg':
drivers/usb/gadget/omap_udc.c:1389: error: incompatible type for
argument 1 of 'gadget_is_otg'
gadget_is_otg() is defined as
static inline int gadget_is_otg(struct usb_gadget *g) { ...
and the call is
gadget_is_otg(udc->gadget)
Which fix do you propose for this?
Best regards
Dirk
next prev parent reply other threads:[~2007-10-30 16:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 19:55 [PATCH] ARM: OMAP: Fix usb gadget related compile errors and typo Dirk Behme
2007-10-29 20:11 ` David Brownell
2007-10-29 20:44 ` Felipe Balbi
2007-10-29 21:33 ` David Brownell
2007-10-29 21:45 ` Felipe Balbi
2007-10-29 22:42 ` David Brownell
2007-10-29 22:52 ` Felipe Balbi
2007-10-30 16:37 ` Dirk Behme [this message]
2007-10-30 17:00 ` David Brownell
2007-11-01 9:00 ` Tony Lindgren
2007-11-01 16:28 ` Dirk Behme
2007-11-15 20:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47275DDC.7060002@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=david-b@pacbell.net \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox