From: Arnd Bergmann <arnd@arndb.de>
To: Rajendra Nayak <rnayak@ti.com>
Cc: nm@ti.com, devicetree@vger.kernel.org, s-anna@ti.com,
tony@atomide.com, bcousson@baylibre.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 5/5] ARM: DRA7: Add support for soc_is_dra74x() and soc_is_dra72x() varients
Date: Tue, 29 Apr 2014 13:18:30 +0200 [thread overview]
Message-ID: <4792826.emf6IohHd6@wuerfel> (raw)
In-Reply-To: <1398769513-8736-6-git-send-email-rnayak@ti.com>
On Tuesday 29 April 2014 16:35:13 Rajendra Nayak wrote:
> @@ -393,7 +395,12 @@ IS_OMAP_TYPE(3430, 0x3430)
>
> #if defined(CONFIG_SOC_DRA7XX)
> #undef soc_is_dra7xx
> +#undef soc_is_dra74x
> +#undef soc_is_dra72x
> #define soc_is_dra7xx() (of_machine_is_compatible("ti,dra7"))
> +#define soc_is_dra74x() (of_machine_is_compatible("ti,dra74"))
> +#define soc_is_dra72x() (of_machine_is_compatible("ti,dra72"))
> +
You shouldn't normally have to define these. Why are they needed?
Maybe it's better to wait for a user to show up, and then we can decide
whether we actually want to have them this way, or if there is a better
solution for the particular use case.
Normally, we'd want to make run-time decisions based on properties
of the nodes a driver is working on, not the global machine compatible
string.
Arnd
next prev parent reply other threads:[~2014-04-29 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 11:05 [PATCH v4 0/5] ARM: DRA7: Add support for DRA72x devices Rajendra Nayak
2014-04-29 11:05 ` [PATCH v4 1/5] ARM: dts: dra7-evm: Remove the wrong and undocumented compatible Rajendra Nayak
2014-04-29 11:05 ` [PATCH v4 2/5] ARM: dts: Add support for DRA72x family of devices Rajendra Nayak
2014-04-29 11:16 ` Arnd Bergmann
2014-04-29 11:05 ` [PATCH v4 3/5] ARM: OMAP2+: Replace all __initdata with __initconst for const init Rajendra Nayak
[not found] ` <1398769513-8736-1-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2014-04-29 11:05 ` [PATCH v4 4/5] ARM: OMAP2+: Add machine entry for dra72x devices Rajendra Nayak
[not found] ` <1398769513-8736-5-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2014-04-29 11:16 ` Arnd Bergmann
2014-04-29 11:05 ` [PATCH v4 5/5] ARM: DRA7: Add support for soc_is_dra74x() and soc_is_dra72x() varients Rajendra Nayak
2014-04-29 11:18 ` Arnd Bergmann [this message]
2014-04-29 11:19 ` Rajendra Nayak
2014-05-06 16:28 ` Tony Lindgren
2014-05-07 4:38 ` Rajendra Nayak
2014-05-06 5:45 ` [PATCH v4 0/5] ARM: DRA7: Add support for DRA72x devices Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4792826.emf6IohHd6@wuerfel \
--to=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=rnayak@ti.com \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox