RE: [PATCH 04/10 v1] arm: omap: usb: create common enums and structures for ehci and ohci

[Keshava Munegowda <keshava_mgowda@ti.com>]

> -----Original Message-----
> From: Felipe Balbi [mailto:balbi@ti.com]
> Sent: Tuesday, March 01, 2011 6:08 PM
> To: Felipe Balbi
> Cc: Keshava Munegowda; linux-usb@vger.kernel.org;
linux-omap@vger.kernel.org; Anand Gadiyar; Partha
> Basak
> Subject: Re: [PATCH 04/10 v1] arm: omap: usb: create common enums and
structures for ehci and ohci
>
> On Tue, Mar 01, 2011 at 02:35:43PM +0200, Felipe Balbi wrote:
> > On Tue, Mar 01, 2011 at 05:07:34PM +0530, Keshava Munegowda wrote:
> > > > -----Original Message-----
> > > > From: Felipe Balbi [mailto:balbi@ti.com]
> > > > Sent: Tuesday, March 01, 2011 4:20 PM
> > > > To: Keshava Munegowda
> > > > Cc: linux-usb@vger.kernel.org; linux-omap@vger.kernel.org;
balbi@ti.com;
> > > gadiyar@ti.com; p-
> > > > basak2@ti.com
> > > > Subject: Re: [PATCH 04/10 v1] arm: omap: usb: create common enums
and
> > > structures for ehci and ohci
> > > >
> > > > On Mon, Feb 28, 2011 at 10:01:46PM +0530, Keshava Munegowda wrote:
> > > > > Create the ehci and ohci specific platform data structures.
> > > > > The port enum values are made common for both ehci and ohci.
> > > > >
> > > > > Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
> > > >
> > > > Applying: arm: omap: usb: create common enums and structures for
ehci
> > > and ohci
> > > > error: patch failed: drivers/usb/host/ehci-omap.c:409
> > > > error: drivers/usb/host/ehci-omap.c: patch does not apply
> > > > Patch failed at 0005 arm: omap: usb: create common enums and
structures
> > > for ehci and ohci
> > > > When you have resolved this problem run "git am --resolved".
> > > > If you would prefer to skip this patch, instead run "git am
--skip".
> > > > To restore the original branch and stop patching run "git am
--abort".
> > > >
> > > > Which tree did you use as base for these patches ? I'm trying to
apply
> > > > on top of v.2.6.38-rc6
> > >
> > > Balbi
> > >
> > > I tried at my side on l2.6.38-rc6 , it dint see any failures its
working.
> > >
> > > These patches are apply correctly on l2.6.38-rc6
> > > Commit id: f5412be599602124d2bdd49947b231dd77c0bf99
> > >
> > > Please check; its working my side.
> >
> > You have to rebase on top of this patch which is going to mainline:
>
> BTW, bear in mind you should not cause a regression of that patch. A
> simple rebase is easy to do, but you cannot remove that feature
> introduced by Anand.

Yes, I will do the rebase, and I will send patches soon.





> --
> balbi