From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Date: Wed, 30 Sep 2015 10:15:25 +0200 Message-ID: <4815825.NCBBBMgLGf@wuerfel> References: <1443559446-26969-1-git-send-email-balbi@ti.com> <1443559446-26969-12-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1443559446-26969-12-git-send-email-balbi@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: Felipe Balbi , Tony Lindgren , daniel.lezcano@linaro.org, Linux Kernel Mailing List , tglx@linutronix.de, Linux OMAP Mailing List List-Id: linux-omap@vger.kernel.org On Tuesday 29 September 2015 15:44:06 Felipe Balbi wrote: > All devices should have a default status. Ignoring > the arguments if it should be 'okay' or 'disabled' > by default, let's set them all the 'disabled' and > have boards enable 32k counter. > > Signed-off-by: Felipe Balbi > The patch looks good, but the description is slightly incorrect: There is no reason to list "status='okay'" other than overriding the 'disabled' status. I'd phrase it something like: "We want the use of the 32k counter to be a per-board setting, so let's disable it by default in each dtsi file and override the setting in the boards. Any board that does not wire up the counter should leave it disabled". However, if you really want all boards to provide the counter all the time, I'd argue that we're better off dropping this patch. We use the status="disabled" trick for anything that may or may not be working based on the board design, but things that are present everywhere don't need this. Arnd