From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH 2/3] N810: Don't export camera orientation Date: Wed, 14 May 2008 15:04:37 +0300 Message-ID: <482AD555.40905@nokia.com> References: <12106946631016-git-send-email-sakari.ailus@nokia.com> <1210694663310-git-send-email-sakari.ailus@nokia.com> <20147cff763adbdb887ad31373040efc@felipebalbi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.nokia.com ([192.100.122.233]:17121 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754921AbYENMFU (ORCPT ); Wed, 14 May 2008 08:05:20 -0400 In-Reply-To: <20147cff763adbdb887ad31373040efc@felipebalbi.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: ext Felipe Balbi Cc: linux-omap@vger.kernel.org ext Felipe Balbi wrote: Hello Felipe, and thanks for reviewing the patch! :) > On Tue, 13 May 2008 19:04:22 +0300, Sakari Ailus > wrote: >> @@ -298,12 +340,21 @@ static int tcm825x_ifparm(struct v4l2_ifparm *p) >> return 0; >> } >> >> +static int tcm825x_is_upside_down(void) >> +{ >> + if (machine_is_nokia_n810()) >> + return 1; >> + >> + return 0; >> +} >> + >> const struct tcm825x_platform_data n800_tcm825x_platform_data = { >> - .is_okay = tcm825x_is_okay, >> - .power_set = tcm825x_power_set, >> - .default_regs = tcm825x_default_regs, >> - .needs_reset = tcm825x_needs_reset, >> - .ifparm = tcm825x_ifparm, >> + .is_okay = tcm825x_is_okay, >> + .power_set = tcm825x_power_set, >> + .default_regs = tcm825x_default_regs, >> + .needs_reset = tcm825x_needs_reset, >> + .ifparm = tcm825x_ifparm, >> + .is_upside_down = tcm825x_is_upside_down, > > ok, now i got your point but this could be: > .is_upside_down = machine_is_nokia_n810() ? 1 : 0, This doesn't work because machine_is_nokia_n810() is not constant. Anyway, tcm825x_is_upside_down can be made more simple as it could just return machine_is_nokia_n810(). I'll send new patches. -- Sakari Ailus sakari.ailus@nokia.com